Review main Merged

93636[TASK] Remove trigger_error() from FileMountStorageAdapter deprecation

Josua Vogel CR +2 V +2 Normal +11 −55 updated 04/13/26, 11:13

Commit message

The FileMountStorageAdapter and the YAML configuration option
`persistenceManager.allowedFileMounts` were deprecated in v14.2
(Deprecation-108653). However, the trigger_error(E_USER_DEPRECATED)
calls caused the TYPO3 core to emit its own deprecation warnings,
which violates the core contribution guideline that the core must
not trigger its own deprecations.

The root cause: The core's base config.yaml ships with a non-empty
default `allowedFileMounts: { 10: '1:/form_definitions/' }`. This
default must remain to avoid a breaking change. But any code path
that checked whether the FileMountStorageAdapter is available
(e.g. FormPersistenceManager::getAccessibleStorageAdapters()) would
call getAllowedFileMounts() or isAccessible(), which triggered the
deprecation — even during normal bootstrapping where no file-mount
storage was actually used.

Since FileMountStorageAdapter is marked `@internal`, no trigger_error()
is required per TYPO3 deprecation guidelines. Internal classes can
be changed or removed without a formal deprecation log entry.

The deprecation is communicated through:
- The RST changelog (Deprecation-108653)
- The `@deprecated` PHPDoc annotation on the class and config method
- The upgrade wizard "Migrate file-based forms to database storage"
- The CLI command `form:definition:transfer`

These tools provide far more actionable guidance to integrators than
a generic deprecation log entry.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 813

  1. Josua Vogel uploaded patch set 1 04/13/26, 06:24

  2. core-ci voted on patch set 1 V +1 04/13/26, 06:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100057

  3. Oliver Klee updated the commit message in patch set 2 V +1 04/13/26, 06:54

  4. core-ci voted on patch set 2 V -1 04/13/26, 07:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100058

  5. core-ci commented on patch set 2 04/13/26, 07:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100058

  6. Oliver Klee rebased onto patch set 3 V -1 04/13/26, 07:11

  7. core-ci voted on patch set 2 V +1 04/13/26, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100058

  8. core-ci voted on patch set 3 V +1 04/13/26, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100059

  9. Stefan Bürk voted on patch set 3 CR +1 V +1 04/13/26, 10:51

  10. Christian Kuhn commented on patch set 3 CR +1 V +1 04/13/26, 10:54

    agreed. i kinda dislike it since that's not what we usually want, but it is a solution for the get-rid-of-fal-in-ext-form approach at that point in time of v14 development, and i see no different solution, either.
  11. Oliver Klee voted on patch set 3 V +1 04/13/26, 10:59

  12. Stefan Bürk voted on patch set 3 CR +2 V +2 04/13/26, 11:13

  13. Stefan Bürk merged patch set 4 04/13/26, 11:13