Review 13.4 Merged

93645[TASK] Update PHPStan to v2.1.47

Garvin Hicking CR +2 V +2 Easy +12 −12 updated 04/13/26, 16:42

Commit message

Updates PHPStan to the latest version 2.1.47.

New PHPStan version no longer reports one false
negatives, and one new irrelevant nullability
check.

Executed commands:

> Build/Scripts/runTests.sh -s composer -- \
      require --dev phpstan/phpstan:^2.1.47
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Garvin Hicking commented on patch set 1 04/13/26, 16:23

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon * composer.json * composer.lock * typo3/sysext/core/Classes/SysLog/Repository/LogEntryRepository.php
  2. Garvin Hicking uploaded patch set 2 04/13/26, 16:29

    adapt
  3. Garvin Hicking marked it ready for review 04/13/26, 16:29

  4. core-ci voted on patch set 1 V -1 04/13/26, 16:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100095

  5. Garvin Hicking commented on patch set 2 04/13/26, 16:30

    Please note: The 13.4 backport contains one addition to the baseline due to a new redundant "is_array" check. I'd rather not touch this place in v13, but feel free to resolve this differently.
  6. Christian Kuhn commented on patch set 2 04/13/26, 16:36

    Reply

    fine with me.
  7. core-ci voted on patch set 2 V +1 04/13/26, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100098

  8. Stefan Bürk commented on patch set 2 CR +1 V +1 04/13/26, 16:39

    Reply

    ack.
  9. Oliver Klee voted on patch set 2 CR +1 V +1 04/13/26, 16:39

  10. Garvin Hicking voted on patch set 2 CR +2 V +2 04/13/26, 16:42

  11. Garvin Hicking merged patch set 3 04/13/26, 16:42