Review 13.4 Merged

93676[BUGFIX] Fix isSubMenu excluding Link pages from menu children

Stefan Bürk CR +2 V +2 Easy +10 −1 updated 04/15/26, 07:58

Commit message

isSubMenu() used a hardcoded field list when fetching child pages
in a batch query. The checkValidLinkOfPage() method introduced in
14.0 requires the "link" field, which was absent from that list.
As a result, all Link pages (doktype=3) were removed during
validation, causing isSubMenu() to cache a negative result and
skip the submenu query entirely, leaving children empty.

Fix by using * in the batch query to ensure all fields required
by checkShortcuts validation are available. Strip the result down
to only the fields consumed by the foreach loop before caching
to keep the runtime cache lean.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 04/15/26, 07:47

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/15/26, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100233

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 04/15/26, 07:58

  4. Stefan Bürk merged patch set 2 04/15/26, 07:58