Review main Work in progress Stale

93693[TASK] Pull down UID and PID accessors of `AbstractDomainObject`

Oliver Klee CR 0 V 0 Normal +71 −41 updated 06/10/26, 15:18

Commit message

As `AbstractDomainObject` is an `@internal` class, calling
`getUid()`, `getPid()` or `setPid()` from an extension creates
PHPStan warnings like this:

> Error: Call to method setPid() of internal class
> TYPO3\CMS\Extbase\DomainObject\AbstractDomainObject
> from outside its root namespace TYPO3.

Pull down those methods to the subclasses to allow extensions
to be PHPStan-warning-free (at least in this regard).

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 4
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/93/93693/4 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/93/93693/4 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 3

Issues 3

Files 4

Review log 913

  1. Oliver Klee uploaded patch set 1 04/16/26, 14:34

  2. Oliver Klee marked it work in progress 04/16/26, 14:34

  3. Oliver Klee wrote 04/16/26, 14:35

    Topic set to extbase
  4. core-ci voted on patch set 1 V -1 04/16/26, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100333

  5. Oliver Klee uploaded patch set 2 V -1 04/16/26, 14:49

  6. Oliver Klee marked it ready for review 04/16/26, 14:49

  7. Oliver Klee commented on patch set 2 04/16/26, 14:50

  8. core-ci voted on patch set 2 V +1 04/16/26, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100334

  9. Oliver Klee marked it work in progress 04/16/26, 17:17

  10. Oliver Klee uploaded patch set 3 V +1 06/03/26, 10:33

  11. core-ci voted on patch set 3 V +1 06/03/26, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102882

  12. Oliver Klee rebased onto patch set 4 V +1 06/10/26, 15:06

  13. core-ci voted on patch set 4 V +1 06/10/26, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103347