Review 13.4 Merged

93731[BUGFIX] Respect "0" max files setting when rotating logs

Andreas Kienast CR +2 V +2 Easy +36 −3 updated 04/18/26, 14:32

Commit message

The documentation of `RotatingFileWriter` states [1] that setting
`maxFiles` to 0 keeps all log files after rotation, which isn't the
case right now.

This commit now checks whether the configuration is accordingly set,
including a new test to verify the bugfix.

[1] https://docs.typo3.org/permalink/t3coreapi:confval-rotating-file-writer-maxfiles

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Andreas Kienast commented on patch set 1 04/18/26, 13:44

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/18/26, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100459

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 04/18/26, 14:32

  4. Andreas Kienast merged patch set 2 04/18/26, 14:32