Review main Merged

93908[BUGFIX] Avoid CSS-unsafe flex form field names in section DOM ids

Christian Kuhn CR +2 V +2 Easy +32 −6 updated 05/02/26, 17:33

Commit message

Migrating inline record panels to Bootstrap Collapse routes the
flex form section container DOM id through Bootstrap's
data-bs-target attribute, which is parsed as a CSS selector.

When section element names contain dots, they are read as class
separators, so an existing `<settings.section>` element silently
misses its accordion toggle target.

The patch hashes the flex form field name when assembling the
DOM id and the parent section container reference, mirroring
the md5() treatment that elementBaseName already received in
the same lines.

The styleguide flex_2 fixture is adapted to have a section
with a dotted name, and a playwright test verifies expanding
a section works.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 67

  1. Christian Kuhn uploaded patch set 1 05/02/26, 13:48

  2. core-ci voted on patch set 1 V +1 05/02/26, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101393

  3. Stefan Bürk voted on patch set 1 CR +1 05/02/26, 16:03

  4. Stefan Bürk voted on patch set 1 V +1 05/02/26, 16:25

  5. Anja Leichsenring voted on patch set 1 CR +1 V +1 05/02/26, 17:09

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 05/02/26, 17:10

  7. Christian Kuhn merged patch set 2 05/02/26, 17:33