Review 14.3 Merged

93957[TASK] Migrate codeception InstallTool tests to playwright

Christian Kuhn CR +2 V +2 Expert +607 −649 updated 05/05/26, 00:19

Commit message

The patch migrates the InstallTool cests to a single playwright
spec in Build/tests/playwright/e2e/install-tool/.

The standalone install tool needs 'ENABLE_INSTALL_TOOL' file
present, which is harder to accomplish in playwright than with
codeception. The solution is to have a BE middleware that
creates the file, which can be called by tests. This is of
course a 'for testing purposes, only' solution, and lives
in a helper extension within monorepo Build/.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 13

Review log 48

  1. Christian Kuhn commented on patch set 1 05/04/26, 23:42

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 05/04/26, 23:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101507

  3. Christian Kuhn uploaded patch set 2 V -1 05/04/26, 23:51

  4. core-ci voted on patch set 2 V -1 05/05/26, 00:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101508

  5. core-ci commented on patch set 2 05/05/26, 00:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101508

  6. core-ci voted on patch set 2 V +1 05/05/26, 00:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101508

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 05/05/26, 00:19

  8. Christian Kuhn merged patch set 3 05/05/26, 00:19