Review main Abandoned

94001[BUGFIX] Refine Test for Enable Letter Spacing with Bookmarklets in Modal

Christian Jung CR -2 V -1 Easy +4 −4 updated 05/11/26, 07:16

Commit message

In the Backend Page module, the Add content button
opens a modal dialog to add new content elements to a page.

When user-defined text spacing is enabled (e.g. via the
BITV test bookmarklet Textabstände or a browser extension
for WCAG text spacing), only the modal heading reflects the
changed text spacing, whereas the remaining text
(descriptions, categories, buttons, labels, etc.) does not
update accordingly.

Review

  • Code review CR -2
    • Christian Kuhn -2
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 1

Review log 47

  1. Christian Jung uploaded patch set 1 05/06/26, 06:06

  2. Christian Jung updated the commit message in patch set 2 05/06/26, 06:08

  3. core-ci voted on patch set 1 V -1 05/06/26, 06:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101595

  4. core-ci voted on patch set 2 V -1 05/06/26, 06:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101596

  5. core-ci commented on patch set 2 05/06/26, 06:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101596

  6. Christian Kuhn commented on patch set 2 CR -2 05/06/26, 07:09

    Unresolved

    Hey. Sorry, need to block here: we're about to remove the last Cest.php files with https://review.typo3.org/c/Packages/TYPO3.CMS/+/93996 I need to ask you to either port your patch to playwright when the big one is merged, or to abandon.
  7. Christian Jung abandoned the change 05/11/26, 07:16