Review 14.3 Merged

94011[BUGFIX] Cleanup fluidAdditionalAttributes when form field is set optional

Garvin Hicking CR +2 V +2 Easy +6 −2 updated 05/07/26, 06:57

Commit message

When unchecking a required validator in the form editor inspector, the
`view/inspector/removeCollectionElement/perform` event was published
before the associated property path was unset on the form element model.
This caused the collection element removal to be processed while the
property data was still present, resulting in inconsistent state.

Additionally, saving a form definition via FormDefinitionArrayConverter
left empty arrays in the data after removeHmacData() was applied.
Removing _orig_* HMAC entries can reduce arrays such as
fluidAdditionalAttributes to an empty state. These empty arrays were
not cleaned up and could be persisted unnecessarily in the form YAML.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Garvin Hicking commented on patch set 1 05/07/26, 06:34

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 05/07/26, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101651

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 05/07/26, 06:57

  4. Garvin Hicking merged patch set 2 05/07/26, 06:57