94059[!!!][FEATURE] Render a documented class contract in EXT:form frontend
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 9
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/59/94059/9 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/59/94059/9 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Merge conflicts 7
- main 97596[FEATURE] Add webhook finisher to the form framework
- main 95093[FEATURE] Allow form elements on summary page
- main 94093[FEATURE] Use translation domains for form backend labels
- main 96364[FEATURE] Allow disabling duplication of forms
- main 94503[WIP][TASK] Save finishers in dedicated table
- main 93558[POC][FEATURE] form <3 tca
- main 67656[FEATURE] Add CSRF protection for frontend forms (ext:form)
Issues 1
Files 158
- Build/tests/playwright/e2e/frontend/form.spec.ts+1 −1
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-109860-FormFrontendCssClassSystem.rstnew+122 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-109860-FormFrontendCssClassSystem.rstnew+196 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/AdvancedPassword.yaml+0 −6
- typo3/sysext/form/Configuration/Form/Base/FormElements/Checkbox.yaml+0 −5
- typo3/sysext/form/Configuration/Form/Base/FormElements/ContentElement.yaml+0 −1
- typo3/sysext/form/Configuration/Form/Base/FormElements/CountrySelect.yaml+0 −5
- typo3/sysext/form/Configuration/Form/Base/FormElements/Date.yaml+0 −4
- typo3/sysext/form/Configuration/Form/Base/FormElements/Email.yaml+0 −5
- typo3/sysext/form/Configuration/Form/Base/FormElements/Fieldset.yaml+0 −4
- typo3/sysext/form/Configuration/Form/Base/FormElements/FileUpload.yaml+0 −4
- typo3/sysext/form/Configuration/Form/Base/FormElements/Form.yaml+0 −13
- typo3/sysext/form/Configuration/Form/Base/FormElements/GridRow.yaml+0 −3
- typo3/sysext/form/Configuration/Form/Base/FormElements/Hidden.yaml+0 −4
- typo3/sysext/form/Configuration/Form/Base/FormElements/Honeypot.yaml+0 −3
- typo3/sysext/form/Configuration/Form/Base/FormElements/ImageUpload.yaml+0 −4
- typo3/sysext/form/Configuration/Form/Base/FormElements/MultiCheckbox.yaml+0 −6
- typo3/sysext/form/Configuration/Form/Base/FormElements/MultiSelect.yaml+0 −5
- typo3/sysext/form/Configuration/Form/Base/FormElements/Number.yaml+0 −5
- typo3/sysext/form/Configuration/Form/Base/FormElements/Password.yaml+0 −5
Show 138 more files
- typo3/sysext/form/Configuration/Form/Base/FormElements/RadioButton.yaml+0 −6
- typo3/sysext/form/Configuration/Form/Base/FormElements/SingleSelect.yaml+0 −5
- typo3/sysext/form/Configuration/Form/Base/FormElements/StaticText.yaml+0 −1
- typo3/sysext/form/Configuration/Form/Base/FormElements/SummaryPage.yaml+0 −4
- typo3/sysext/form/Configuration/Form/Base/FormElements/Telephone.yaml+0 −5
- typo3/sysext/form/Configuration/Form/Base/FormElements/Text.yaml+0 −5
- typo3/sysext/form/Configuration/Form/Base/FormElements/Textarea.yaml+0 −5
- typo3/sysext/form/Configuration/Form/Base/FormElements/Url.yaml+0 −5
- typo3/sysext/form/Documentation/D/FrontendRendering/Index.rst+30 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/properties/confirmationClassAttribute.rst.txtdeleted+0 −40
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/properties/confirmationLabel.rst.txt+1 −5
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/properties/containerClassAttribute.rst.txtdeleted+0 −40
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/properties/elementClassAttribute.rst.txtdeleted+0 −40
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/properties/elementErrorClassAttribute.rst.txtdeleted+0 −40
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Checkbox/properties/containerClassAttribute.rst.txtdeleted+0 −39
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Checkbox/properties/elementClassAttribute.rst.txtdeleted+0 −39
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Checkbox/properties/elementErrorClassAttribute.rst.txtdeleted+0 −39
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Checkbox/properties/value.rst.txt+1 −4
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Date/properties/fluidAdditionalAttributes/pattern.rst.txt+1 −4
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Date/properties/containerClassAttribute.rst.txtdeleted+0 −41
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Date/properties/displayFormat.rst.txt+1 −4
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Date/properties/elementClassAttribute.rst.txtdeleted+0 −41
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Date/properties/elementErrorClassAttribute.rst.txtdeleted+0 −41
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Email/properties/containerClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Email/properties/elementClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Email/properties/elementErrorClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Fieldset/properties/elementClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Fieldset/properties/elementErrorClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/FileUpload/properties/allowedMimeTypes.rst.txt+1 −4
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/FileUpload/properties/containerClassAttribute.rst.txtdeleted+0 −44
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/FileUpload/properties/elementClassAttribute.rst.txtdeleted+0 −44
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/FileUpload/properties/elementErrorClassAttribute.rst.txtdeleted+0 −44
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/FileUpload/properties/saveToFileMount.rst.txt+1 −4
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/GridRow/properties/gridColumnClassAutoConfiguration/viewPorts/classPattern.rst.txt+1 −4
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/GridRow/properties/gridColumnClassAutoConfiguration/gridSize.rst.txt+1 −4
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/GridRow/properties/gridColumnClassAutoConfiguration/viewPorts.rst.txt+1 −4
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/GridRow/properties/containerClassAttribute.rst.txtdeleted+0 −49
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/GridRow/properties/elementClassAttribute.rst.txtdeleted+0 −49
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/GridRow/properties/elementErrorClassAttribute.rst.txtdeleted+0 −49
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Hidden/properties/containerClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Hidden/properties/elementClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Hidden/properties/elementErrorClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Honeypot/properties/containerClassAttribute.rst.txtdeleted+0 −40
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Honeypot/properties/elementClassAttribute.rst.txtdeleted+0 −40
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Honeypot/properties/elementErrorClassAttribute.rst.txtdeleted+0 −40
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Honeypot/properties/renderAsHiddenField.rst.txt+1 −4
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Honeypot/properties/styleAttribute.rst.txt+1 −4
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/ImageUpload/properties/allowedMimeTypes.rst.txt+1 −4
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/ImageUpload/properties/containerClassAttribute.rst.txtdeleted+0 −46
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/ImageUpload/properties/elementClassAttribute.rst.txtdeleted+0 −46
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/ImageUpload/properties/elementErrorClassAttribute.rst.txtdeleted+0 −46
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/ImageUpload/properties/imageLinkMaxWidth.rst.txt+1 −4
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/ImageUpload/properties/imageMaxHeight.rst.txt+1 −4
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/ImageUpload/properties/imageMaxWidth.rst.txt+1 −4
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/ImageUpload/properties/saveToFileMount.rst.txt+1 −4
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/MultiCheckbox/properties/containerClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/MultiCheckbox/properties/elementClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/MultiCheckbox/properties/elementErrorClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/MultiSelect/properties/containerClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/MultiSelect/properties/elementClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/MultiSelect/properties/elementErrorClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Number/properties/containerClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Number/properties/elementClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Number/properties/elementErrorClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Password/properties/containerClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Password/properties/elementClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Password/properties/elementErrorClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/RadioButton/properties/containerClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/RadioButton/properties/elementClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/RadioButton/properties/elementErrorClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/SingleSelect/properties/containerClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/SingleSelect/properties/elementClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/SingleSelect/properties/elementErrorClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Telephone/properties/containerClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Telephone/properties/elementClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Telephone/properties/elementErrorClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Text/properties/containerClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Text/properties/elementClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Text/properties/elementErrorClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Textarea/properties/containerClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Textarea/properties/elementClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Textarea/properties/elementErrorClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Url/properties/containerClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Url/properties/elementClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Url/properties/elementErrorClassAttribute.rst.txtdeleted+0 −38
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword.rst+0 −12
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Checkbox.rst+0 −9
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Date.rst+0 −9
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Email.rst+0 −9
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Fieldset.rst+0 −6
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/FileUpload.rst+0 −9
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/GridRow.rst+0 −9
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Hidden.rst+0 −9
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Honeypot.rst+0 −9
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/ImageUpload.rst+0 −9
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/MultiCheckbox.rst+0 −9
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/MultiSelect.rst+0 −9
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Number.rst+0 −9
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Password.rst+0 −9
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/RadioButton.rst+0 −9
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/SingleSelect.rst+0 −9
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Telephone.rst+0 −9
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Text.rst+0 −9
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Textarea.rst+0 −9
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Url.rst+0 −9
- typo3/sysext/form/Documentation/I/HowTos/CustomFormElement/_GenderSelect.fluid.html+25 −33
- typo3/sysext/form/Resources/Private/Frontend/Partials/Field/Field.fluid.html+9 −6
- typo3/sysext/form/Resources/Private/Frontend/Partials/Field/Required.fluid.html+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/Form/Navigation.fluid.html+4 −4
- typo3/sysext/form/Resources/Private/Frontend/Partials/AdvancedPassword.fluid.html+11 −9
- typo3/sysext/form/Resources/Private/Frontend/Partials/Checkbox.fluid.html+6 −7
- typo3/sysext/form/Resources/Private/Frontend/Partials/ContentElement.fluid.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/CountrySelect.fluid.html+4 −4
- typo3/sysext/form/Resources/Private/Frontend/Partials/Date.fluid.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/Email.fluid.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/Fieldset.fluid.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/FileUpload.fluid.html+14 −14
- typo3/sysext/form/Resources/Private/Frontend/Partials/GridRow.fluid.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/Hidden.fluid.html+0 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/Honeypot.fluid.html+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/ImageUpload.fluid.html+16 −16
- typo3/sysext/form/Resources/Private/Frontend/Partials/MultiCheckbox.fluid.html+16 −19
- typo3/sysext/form/Resources/Private/Frontend/Partials/MultiSelect.fluid.html+4 −4
- typo3/sysext/form/Resources/Private/Frontend/Partials/Number.fluid.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/Password.fluid.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/RadioButton.fluid.html+15 −18
- typo3/sysext/form/Resources/Private/Frontend/Partials/SingleSelect.fluid.html+4 −4
- typo3/sysext/form/Resources/Private/Frontend/Partials/StaticText.fluid.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/SummaryPage.fluid.html+9 −9
- typo3/sysext/form/Resources/Private/Frontend/Partials/Telephone.fluid.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/Text.fluid.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/Textarea.fluid.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Partials/Url.fluid.html+2 −2
- typo3/sysext/form/Resources/Private/Frontend/Templates/Form.fluid.html+2 −3
- typo3/sysext/form/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Forms/MarkupTestForm.form.yamlnew+105 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/FormMarkupScenario.yamlnew+40 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/FrontendMarkupTest.phpnew+177 −0
Review log 2534
Show 89 earlier messages
-
Josua Vogel uploaded patch set 1 05/11/26, 13:17
-
Josua Vogel marked it work in progress 05/11/26, 13:17
-
core-ci voted on patch set 1 V -1 05/11/26, 13:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101830
-
Chris Müller commented on patch set 1 05/11/26, 16:48
I am curious about the reason behind this? Actually, I like the current implementation as I don't have to override the whole template when I just want to adjust the class names. -
Josua Vogel commented on patch set 1 05/14/26, 15:39
Reply
My intention is to have a single place for frontend rendering: the template file. I’d prefer not to mix the Fluid template with YAML configuration. I believe this approach is more straightforward, but I’m happy to discuss it. -
Chris Müller commented on patch set 1 05/14/26, 16:12
Reply
In understand your point. But for me it means, I have to copy all the relevant partials of the form elements to the site package to adjust only the class names - so I cannot benefit from fixes of new releases. Or do I miss something? -
Josua Vogel commented on patch set 1 05/14/26, 16:44
Reply
No, that´s right. I never use the default templates. I have to think about it. -
Josua Vogel commented on patch set 1 05/14/26, 17:00
Reply
another point: If you want to modify the classes of default content element, you need to override the templates too. That would further standardize the approach in the core -
Josua Vogel commented on patch set 1 05/15/26, 09:46
and I want to remove the bootstrap classes from the frontend templates in another patch
-
Josua Vogel uploaded patch set 2
V -105/21/26, 20:18 -
Josua Vogel marked it ready for review 05/21/26, 20:19
-
core-ci voted on patch set 2 V +1 05/21/26, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102336
-
Garvin Hicking commented on patch set 2 CR -1 05/22/26, 06:38
I'm sorry but I have to agree with Chris here. I think this is a heavy burden for integrators who want to use a working form template and easily customize it. The templates carry a lot of logic that integrators do not want to maintain I think (otherwise they would have to keep up with a lot of maintenance as seen in v14, like jquery or field removal or translations). So suddenly an integrator needs to maintain actual functionality of complex templates they might not understand, when all they want is to match usual HTML elements to their site's CSS / frontend framework. I do understand that architecturally it blurs the borders of having mixed responsibility for YAML to influence layout. But on the other hand, I would argue YAML should be the sole entry point into "common configuration". People who want a clearer distinction currently have the ability to insert their stripped down templates already, which fixate frontend layout. So we would only take away a valid use case, while the other use case can already be satisfied. Also, think of third party extensions that provide pre-build forms, and want to match them to the extensions layout. They would need to ship and maintain the whole EXT:form frontend templates then. And if integrators override EXT:form templates themselves, they would again have to override the whole templates for a custom CSS class again. This is why I think the CSS classnames for simple frontend configuration is much needed and should stay. Also I think this would be an impactful breaking change that would probably deserve deprecation first. -
Benjamin Kott commented on patch set 2 05/22/26, 09:52
i am in favor removing it from the configuration but i think we should not simply move the css classes but define a new set of classes not occupied by bootstrap or else already and ship some custom css with some css properties to make adjustments easy -
Garvin Hicking commented on patch set 2 05/22/26, 09:54
Reply
ack. we can then create a site set that delivers the default CSS for the new classes so its less breaking. Existing customizations would need to adapt to the new classes, so that's definitely breaking and would need an ReST file. -
Josua Vogel marked it work in progress 05/26/26, 12:53
-
Josua Vogel uploaded patch set 3
CR -1V +105/29/26, 05:35 -
core-ci voted on patch set 3 V -1 05/29/26, 05:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102585
-
Josua Vogel uploaded patch set 4
V -106/07/26, 17:42 -
Josua Vogel uploaded patch set 5 06/07/26, 17:45
-
Josua Vogel marked it ready for review 06/07/26, 17:46
-
Josua Vogel commented on patch set 5 06/07/26, 17:48
Reply
I've added a rst file. Maybe we could handle the default CSS in a separate patch so this one doesn't get too big. -
Josua Vogel uploaded patch set 6 06/07/26, 17:51
-
core-ci voted on patch set 4 V -1 06/07/26, 17:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103087
-
Josua Vogel updated the commit message in patch set 7 06/07/26, 17:54
-
Josua Vogel commented on patch set 7 06/07/26, 17:58
Reply
DoneReply
AcknowledgedReply
Acknowledged -
Josua Vogel commented on patch set 7 06/07/26, 17:58
Reply
Done -
core-ci voted on patch set 5 V -1 06/07/26, 17:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103088
-
core-ci voted on patch set 6 V +1 06/07/26, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103089
-
core-ci voted on patch set 7 V +1 06/07/26, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103090
-
Josua Vogel rebased onto patch set 8
V +107/26/26, 16:56 -
core-ci voted on patch set 8 V +1 07/26/26, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105427
-
Josua Vogel uploaded patch set 9
V +111/19/26, 11:40 -
core-ci voted on patch set 9 V -1 11/19/26, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115003