Review main Abandoned

94081[BUGFIX] Avoid double-escaped labels in backend record info panel

Gianluigi Martino CR 0 V 0 Easy +4 −4 updated 10/22/26, 15:59

Commit message

Mark pre-escaped field labels in the backend record information panel
as raw output in Fluid instead of removing the controller-side
escaping, to avoid double escaping while keeping the existing
escaping contract of the underlying data. This restores correct
label output like "Mark as 'New' Until" instead of visible HTML
entities.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Gianluigi Martino uploaded patch set 1 05/12/26, 09:55

  2. core-ci voted on patch set 1 V +1 05/12/26, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101888

  3. Oliver Hader commented on patch set 1 07/01/26, 12:18

    My feeling says that it's probably not a good idea, to drop all `htmlspecialchars`...
  4. Gianluigi Martino uploaded patch set 2 V +1 07/01/26, 12:38

  5. core-ci voted on patch set 2 V +1 07/01/26, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104149

  6. Benjamin Franzke commented on patch set 2 07/01/26, 14:46

    Reply

    ack. @gianluca.piccolo@pallino.it can we drop `htmlspecialchars()` in the controller instead of introducing (possibly insecure) `f:format.raw()` in the template?
  7. Matthias Vogel commented on patch set 2 07/15/26, 07:55

    Reply Unresolved

    instead of using ` -> f:format.raw()` we could use Fluids "new" `UnsafeHTML` Class https://github.com/TYPO3/Fluid/pull/1288
  8. Benni Mack abandoned the change 10/22/26, 15:59