Review main Merged

94103[TASK] Remove MD5 password hint from Install Tool alert email

Oliver Hader CR +2 V +2 Easy +1 −5 updated 05/18/26, 18:06

Commit message

The failed-login notification email included the last 5 hex
characters of an unsalted MD5 hash of the submitted password
(substr(md5($password), -5)), intended as a correlation aid
for administrators.

This is not a security vulnerability: the email is delivered
only to the configured warning_email_addr (the site admin),
and a 20-bit partial hash of the attacker's own input leaks
nothing about the administrator's actual credential. The real
password is protected by bcrypt/Argon2 in configuration.

That said, the partial hash provides no meaningful value over
the IP address and timestamp already present in the email,
while introducing an unnecessary dependency on MD5. The
variable assignment and the corresponding template output are
therefore removed.

Thanks to Alex Winder for reporting this finding.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Josua Vogel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 89

  1. Oliver Hader uploaded patch set 1 05/17/26, 19:28

  2. core-ci voted on patch set 1 V +1 05/17/26, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102099

  3. Benni Mack voted on patch set 1 CR +1 05/17/26, 21:08

  4. Josua Vogel voted on patch set 1 CR +1 V +1 05/18/26, 05:37

  5. Oliver Klee voted on patch set 1 CR +1 V +1 05/18/26, 07:38

  6. Stefan Bürk voted on patch set 1 CR +1 V +1 05/18/26, 11:15

  7. Garvin Hicking voted on patch set 1 CR +1 V +1 05/18/26, 11:34

  8. Oliver Hader commented on patch set 1 CR +2 V +2 05/18/26, 18:06

    Thx folks 😊
  9. Oliver Hader merged patch set 2 05/18/26, 18:06