Review 14.3 Abandoned

94184[TASK] Revert "[TASK] Include current site in cache tag collection"

Benjamin Franzke CR 0 V 0 Easy +0 −2 updated 10/15/26, 08:27

Commit message

This reverts commit b390dbe83e08ec37e731950c94ef6740ac35d1e0.

The reverted change introduced a regression by using a plain site
identifier as a cache tag. Site identifiers may contain characters
that are prohibited for cache tags, if the site was manually
created.

Technically these invalid characters are not allowed to
be created via the TYPO3 backend, but TYPO3 currently allows
to use these sites, if they were manually created.

The change was a factual FEATURE and therefore it is reverted
since this cache tag should only be added in TYPO3 v15 when
TYPO3 core ensures that only valid site identifiers are allowed
to be used.

Existing installations can easily add such a tag within a middleware
that adds a cache tag to the cache data collector, or via TypoScript:

```
page = PAGE
page {
  1779954161 = COA
  1779954161.stdWrap.addPageCacheTags = site_{site:identifier}
  1779954161.stdWrap.addPageCacheTags.insertData = 1
}
```

This example has the same problem as the reverted patch, that
invalid site identifiers will cache invalid cache tags, but this
example is here to prove that the patch itself was not needed
to be backported and can therefore be reverted without replacement.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 3

  1. Benjamin Franzke commented on patch set 1 05/28/26, 10:35

    Cherry Picked from branch main.
  2. Benjamin Franzke abandoned the change 05/28/26, 10:38

    Reverted the 14.3 change on gerrit instead to have a gerrit-based revert-marker: https://review.typo3.org/c/Packages/TYPO3.CMS/+/94187
  3. Garvin Hicking wrote 10/15/26, 08:27

    Hashtag added: no-backport