Review 14.3 Merged

94213[BUGFIX] Guard against uninitialized setup array in TranslationService

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 05/30/26, 16:23

Commit message

Add hasSetup() check before calling loadTypoScriptLabelsFromExtension()
in TranslationService::translate(). Without it, getSetupArray() throws
a RuntimeException, which occurs during form finisher execution.

Note: Skipping the override when setup is unavailable means
TypoScript-based label overrides (plugin.tx_form._LOCAL_LANG)
are ignored in such finisher context. We need a separate issue
for this to ensure full TypoScript is loaded when finishers
are run.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Oli Bartsch commented on patch set 1 05/30/26, 06:25

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 05/30/26, 06:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102663

  3. core-ci voted on patch set 1 V +1 05/30/26, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102663

  4. Oli Bartsch voted on patch set 1 CR +2 V +2 05/30/26, 16:23

  5. Oli Bartsch merged patch set 2 05/30/26, 16:23