94313[BUGFIX] Restore `titleField` support in `MenuProcessor`
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Christian Kuhn +1
-
Verified V +2 Done
- Garvin Hicking +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1623
-
Anton Danilov uploaded patch set 1 06/04/26, 09:56
-
core-ci voted on patch set 1 V +1 06/04/26, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102942
-
Martin Clewing voted on patch set 1 V +1 06/04/26, 13:26
-
Martin Clewing wrote 06/04/26, 13:27
Removed reviewer Martin Clewing with the following votes: * Verified+1 by Martin Clewing -
Anton Danilov uploaded patch set 2
V +106/04/26, 15:17MenuProcessor Functional tests -
core-ci voted on patch set 2 V -1 06/04/26, 15:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102954
-
Anton Danilov uploaded patch set 3
V -106/04/26, 15:44 -
core-ci voted on patch set 3 V +1 06/04/26, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102956
-
Benni Mack updated the commit message in patch set 4
V +106/04/26, 16:22 -
core-ci voted on patch set 4 V +1 06/04/26, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102961
-
Anton Danilov uploaded patch set 5
V +106/04/26, 19:00 -
core-ci voted on patch set 5 V +1 06/04/26, 19:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102982
-
Garvin Hicking voted on patch set 5 CR +1 V +1 06/05/26, 08:01
-
Christian Kuhn commented on patch set 5 CR -1 06/05/26, 22:21
on it. the change itself looks good to me - i'll only change test cosmetics.MenuProcessorTest.php:158the overall test setup looks overabstracted to me - it will bite us when more tests are added. i'll push a version that inlines stuff to the test. -
Christian Kuhn uploaded patch set 6
CR +1V +106/05/26, 22:29 -
Christian Kuhn voted on patch set 6 CR +1 V +1 06/05/26, 22:34
-
core-ci voted on patch set 6 V +1 06/05/26, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103052
-
Christian Kuhn uploaded patch set 7
CR +1V +106/05/26, 23:24 -
Christian Kuhn voted on patch set 7 CR +1 V +1 06/05/26, 23:24
-
core-ci voted on patch set 7 V +1 06/05/26, 23:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103054
-
Garvin Hicking voted on patch set 7 CR +1 V +1 06/06/26, 09:44
-
Garvin Hicking voted on patch set 7 CR +2 V +2 06/06/26, 10:23
-
Garvin Hicking merged patch set 8 06/06/26, 11:12