Review 14.3 Merged

94373[BUGFIX] Prevent exception when using `BU::daysUntil` w/ DateTime

Garvin Hicking CR +2 V +2 Easy +48 −2 updated 06/09/26, 06:04

Commit message

With #107356 the RecordList was adjusted to utilize RecordInterface
$row values, which meant that a field like `starttime` or
`endtime` might contain a `DateTime(Immutable)` object instead
of an integer timestamp.

The `BackendUtility::dasysUntil()` method only accepted integers,
and otherwise crashed with an exception. This happened for example
when IRRE child elements utilized these date fields.

An example for this was added to EXT:styleguide `Inline expandsingle`
records, and a test to cover this method to deal with both
integers and `DateTimeInterface` objects in `daysUntil`.

Please note the backport to 14.3 does not contain a type declaration
in the method to not be breaking.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 69

  1. Garvin Hicking commented on patch set 1 06/08/26, 19:21

    Cherry Picked from branch main.
  2. Garvin Hicking commented on patch set 2 06/08/26, 19:22

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 06/08/26, 19:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103157

  4. Garvin Hicking commented on patch set 3 06/08/26, 19:43

    Published edit on patch set 2.
  5. core-ci voted on patch set 3 V +1 06/08/26, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103161

  6. core-ci voted on patch set 2 V -1 06/08/26, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103158

  7. Josua Vogel voted on patch set 3 CR +1 V +1 06/09/26, 05:23

  8. Benni Mack voted on patch set 3 CR +2 V +2 06/09/26, 06:04

  9. Benni Mack merged patch set 4 06/09/26, 06:04