Review main Ready for review

94439[BUGFIX] Exclude content elements on non-linkable pages from page links

Maike Kiebele CR 0 V 0 Easy +3 −2 updated 11/10/26, 19:05

Commit message

Content elements on non-linkable page types (e.g. folders) were still shown as link targets in the page link browser. This could lead to invalid frontend links (404) when used in the link wizard.

This patch ensures that content elements on non-linkable pages are no longer offered as link targets.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/39/94439/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/39/94439/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 2

Issues 1

Files 1

Review log 811

  1. Maike Kiebele uploaded patch set 1 06/09/26, 12:40

  2. core-ci voted on patch set 1 V +1 06/09/26, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103231

  3. Garvin Hicking commented on patch set 1 06/10/26, 07:45

    PageLinkHandler.php:166

    I am unsure if this short-circuiting of not delivering content elements may pose problems, for example when Content Elements from within a SysFolder should be referenced (for example for the "reference shortcut" picker). So maybe we would need to handle this on the fluid rendering side, but I haven't had the chance to look more deeply into that. If someone can say this with more authority, that would be much appreciated.
  4. Georg Ringer commented on patch set 1 CR +1 V +1 06/10/26, 19:20

    PageLinkHandler.php:166 Reply Unresolved

    those are luckily 2 different things, so it still works to select content elements in ctype:shortcut
  5. Josef Glatz commented on patch set 1 06/11/26, 01:43

    Unresolved

    I understand the patch totally from an editor perspective. But I saw a lot of different project setups where such changes could lead to problems or local core patches the remove this check. Imagine a storagefolder as container for content which is used in „special areas“ of your website. I could also imagine following scenario: news records with related CE‘s: I had already the situation to link to other CE‘s on the same storage folder (which is per definition not linkable). I would more tend to add a feature toggle for such feature as there are projects in the wild which will break. However I can predict things like „the core team tends to not introduce too much feature toggles.“ 😂 I have another perspective on this. As long as TYPO3 is enterprise it could have more feature toggles than a non-enterprise project. I really like the idea in a perfect TYPO3 world. But I‘m not sure if it makes sense as a new core‘s default.
  6. Maike Kiebele updated the commit message in patch set 2 CR +1 V +1 08/06/26, 19:01

  7. Georg Ringer commented on patch set 2 CR +1 V +1 08/06/26, 19:04

    @typo3@josefglatz.at of course it is hard to know if that usecase exists - therefore 14.3 only. if an editor should select the element, shouldn't be a group/select typo3 would be the better choice and not the link browser?
  8. core-ci voted on patch set 2 V +1 08/06/26, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106017

  9. Sebastian Klein commented on patch set 2 08/06/26, 19:52

    Unresolved

    The issue was created for TYPO3 v12. At least in TYPO3 v14 and v15-dev, a link will not be rendered in the frontend if the content element is stored in a page of type "Folder".
  10. Maike Kiebele rebased onto patch set 3 CR +1 V +1 11/10/26, 18:48

  11. core-ci voted on patch set 3 V +1 11/10/26, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113936