94439[BUGFIX] Exclude content elements on non-linkable pages from page links
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/39/94439/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/39/94439/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 2
Issues 1
Files 1
Review log 811
-
Maike Kiebele uploaded patch set 1 06/09/26, 12:40
-
core-ci voted on patch set 1 V +1 06/09/26, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103231
-
Garvin Hicking commented on patch set 1 06/10/26, 07:45
-
Georg Ringer commented on patch set 1 CR +1 V +1 06/10/26, 19:20
PageLinkHandler.php:166Reply Unresolvedthose are luckily 2 different things, so it still works to select content elements in ctype:shortcut -
Josef Glatz commented on patch set 1 06/11/26, 01:43
Unresolved
I understand the patch totally from an editor perspective. But I saw a lot of different project setups where such changes could lead to problems or local core patches the remove this check. Imagine a storagefolder as container for content which is used in „special areas“ of your website. I could also imagine following scenario: news records with related CE‘s: I had already the situation to link to other CE‘s on the same storage folder (which is per definition not linkable). I would more tend to add a feature toggle for such feature as there are projects in the wild which will break. However I can predict things like „the core team tends to not introduce too much feature toggles.“ 😂 I have another perspective on this. As long as TYPO3 is enterprise it could have more feature toggles than a non-enterprise project. I really like the idea in a perfect TYPO3 world. But I‘m not sure if it makes sense as a new core‘s default. -
Maike Kiebele updated the commit message in patch set 2
CR +1V +108/06/26, 19:01 -
Georg Ringer commented on patch set 2 CR +1 V +1 08/06/26, 19:04
@typo3@josefglatz.at of course it is hard to know if that usecase exists - therefore 14.3 only. if an editor should select the element, shouldn't be a group/select typo3 would be the better choice and not the link browser? -
core-ci voted on patch set 2 V +1 08/06/26, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106017
-
Sebastian Klein commented on patch set 2 08/06/26, 19:52
Unresolved
The issue was created for TYPO3 v12. At least in TYPO3 v14 and v15-dev, a link will not be rendered in the frontend if the content element is stored in a page of type "Folder". -
Maike Kiebele rebased onto patch set 3
CR +1V +111/10/26, 18:48 -
core-ci voted on patch set 3 V +1 11/10/26, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113936
PageLinkHandler.php:166