Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
97436[!!!][FEATURE] Link content elements as records
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 9
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/36/97436/9 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/36/97436/9 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Relation chain 4
-
97436 [!!!][FEATURE] Link content elements as records This change
- main 97675[BUGFIX] Resolve record links in the link preview of the RTE
-
main
97674[BUGFIX] Flush pages linking to a record when the record changes
The chain has patch set 3 of 4, the changes above it need a rebase.
-
main
97673[BUGFIX] Keep parameters and fragment of rich text page links on import
The chain has patch set 2 of 3, the changes above it need a rebase.
Issues 2
Files 61
- typo3/sysext/backend/Classes/Controller/AbstractLinkBrowserController.php+61 −2
- typo3/sysext/backend/Classes/Form/Element/LinkElement.php+2 −11
- typo3/sysext/backend/Classes/LinkHandler/Event/ModifyLinkableRecordsOfPageEvent.phpnew+61 −0
- typo3/sysext/backend/Classes/LinkHandler/PageLinkHandler.php+184 −76
- typo3/sysext/backend/Classes/Service/PageLinkMessageProvider.php+0 −39
- typo3/sysext/backend/Configuration/SiteConfiguration/site_errorhandling.php+1 −1
- typo3/sysext/backend/Configuration/SiteConfiguration/site_route.php+1 −1
- typo3/sysext/backend/Resources/Private/Language/pages/messages.xlf+0 −5
- typo3/sysext/backend/Resources/Private/Language/locallang_layout.xlf+3 −0
- typo3/sysext/backend/Resources/Private/Templates/LinkBrowser/Page.fluid.html+15 −10
- typo3/sysext/backend/Tests/Functional/LinkHandler/Fixtures/PageLinkHandlerEditors.csvnew+8 −0
- typo3/sysext/backend/Tests/Functional/LinkHandler/Fixtures/PageLinkHandlerRecords.csvnew+13 −0
- typo3/sysext/backend/Tests/Functional/LinkHandler/PageLinkHandlerTest.phpnew+228 −0
- typo3/sysext/backend/Tests/Functional/LinkHandler/RecordLinkHandlerTest.php+4 −4
- typo3/sysext/core/Classes/DataHandling/SoftReference/TypolinkSoftReferenceParser.php+2 −19
- typo3/sysext/core/Classes/DataHandling/SoftReference/TypolinkTagSoftReferenceParser.php+5 −22
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-111379-LinksToContentElementsAreRecordLinks.rstnew+197 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Deprecation-111379-NumericFragmentOfPageLinks.rstnew+47 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-111379-ListRecordsOfLinkHandlersInPageTab.rstnew+97 −0
- typo3/sysext/core/Tests/Unit/DataHandling/SoftReference/TypoLinkSoftReferenceParserTest.php+15 −0
Show 41 more files
- typo3/sysext/core/Tests/Unit/DataHandling/SoftReference/TypoLinkTagSoftReferenceParserTest.php+4 −18
- typo3/sysext/fluid_styled_content/Resources/Private/Templates/MenuCategorizedContent.fluid.html+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/RedirectFinisher.php+18 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/RedirectFinisher/Index.rst+8 −4
- typo3/sysext/form/Documentation/I/Config/proto/finishersDefinition/finishers/Redirect.rst+4 −2
- typo3/sysext/form/Tests/Unit/Domain/Finishers/RedirectFinisherTest.php+60 −0
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/EventListener/GroupLinkableContentElementsByColumn.phpnew+75 −0
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+20 −10
- typo3/sysext/frontend/Classes/Upgrades/ContentElementLinkMigration.phpnew+293 −0
- typo3/sysext/frontend/Configuration/page.tsconfig+11 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/SlugScenario.yaml+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/TypoLinkGeneratorTest.php+14 −46
- typo3/sysext/frontend/Tests/Functional/Upgrades/Fixtures/ContentElementLinkMigrationBase.csvnew+22 −0
- typo3/sysext/frontend/Tests/Functional/Upgrades/Fixtures/ContentElementLinkMigrationMigrated.csvnew+22 −0
- typo3/sysext/frontend/Tests/Functional/Upgrades/ContentElementLinkMigrationTest.phpnew+93 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+6 −6
- typo3/sysext/frontend/ext_localconf.php+8 −0
- typo3/sysext/impexp/Tests/Functional/ImportExportTest.php+6 −11
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassConstantMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyProtectedMatcher.php+5 −0
- typo3/sysext/linkvalidator/Classes/EventListener/CheckBrokenRteLinkEventListener.php+24 −9
- typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php+8 −169
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+5 −45
- typo3/sysext/linkvalidator/Documentation/CodeSnippets/Examples/ActivateCustomLinktypeTsConfig.rst.txt+1 −1
- typo3/sysext/linkvalidator/Documentation/Configuration/Index.rst+2 −2
- typo3/sysext/linkvalidator/Documentation/Development/CustomLinkHandler.rst+1 −1
- typo3/sysext/linkvalidator/Documentation/Development/LinkTypeImplementation.rst+1 −1
- typo3/sysext/linkvalidator/Resources/Private/Language/Module/locallang.xlf+0 −3
- typo3/sysext/linkvalidator/Tests/Functional/EventListener/CheckBrokenRteLinkEventListenerTest.php+21 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/broken_record_links.csvnew+4 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/expected_link_with_page_ce.csv+3 −4
- typo3/sysext/linkvalidator/Tests/Functional/Linktype/Fixtures/tt_content_with_content_element_links.csvnew+10 −0
- typo3/sysext/linkvalidator/Tests/Functional/Linktype/RecordLinktypeTest.php+35 −0
- typo3/sysext/linkvalidator/Tests/Functional/LinkAnalyzerTest.php+1 −1
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+1 −1
- typo3/sysext/rte_ckeditor/Configuration/RTE/Editor/LinkBrowser.yaml+8 −7
- typo3/sysext/rte_ckeditor/Documentation/Configuration/Reference.rst+6 −1
- typo3/sysext/rte_ckeditor/Tests/Functional/Fixtures/pages_with_content.csvnew+6 −0
- typo3/sysext/rte_ckeditor/Tests/Functional/RecordList/Controller/BrowseLinksControllerTest.php+33 −0
Review log 1019
-
Oli Bartsch uploaded patch set 1 11/09/26, 13:03
-
core-ci voted on patch set 1 V +1 11/09/26, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113681
-
Oli Bartsch uploaded patch set 2
V +111/09/26, 14:49 -
core-ci voted on patch set 2 V +1 11/09/26, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113713
-
Oli Bartsch uploaded patch set 3
V +111/09/26, 18:52 -
core-ci voted on patch set 3 V +1 11/09/26, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113765
-
Benni Mack rebased onto patch set 4
V +111/10/26, 15:09 -
Benni Mack uploaded patch set 5 11/10/26, 15:14
-
Benni Mack commented on patch set 5 11/10/26, 15:17
I'm abandoning my t3://content approach (96102) in favour of this one: it removes the tt_content knowledge from core and backend, which is what we need to make EXT:frontend optional. I've extended the patch so editors keep their workflow, without reintroducing tt_content in EXT:backend: 1. No separate "Content elements" tab. New generic page TSconfig option TCEMAIN.linkHandler.<id>.displayIn = page: the records of that link handler's table are listed below the selected page in the "Page" tab and linked as records. Reopening such a link opens the page tab with the record selected. If the page tab isn't allowed but the handler is, it falls back to a tab of its own. 2. PageLinkHandler lists the records generically via TcaSchema (sortby/ default_sortby, page language + "all", workspace overlay, live uid, tables_select check) and uses constructor DI now. 3. New PSR-14 event ModifyLinkableRecordsOfPageEvent to filter, sort and group the list. EXT:frontend ships a listener that groups content elements by backend layout columns (resolves the old @todo). 4. DatabaseRecordLinkBuilder adds the cache tag <table>_<uid> for every record link (also if the record can't be linked right now), so pages are flushed when a linked content element is moved, hidden, deleted. 5. RedirectFinisher: a numeric fragment uses the fragment of the record link (new option fragmentRecordLinkIdentifier, default "content") instead of hardcoding "c". Open: an installation that already uses the identifier "content" for another table gets the shipped config merged into its own (documented in the Breaking RST). Maybe the wizard or reports module could detect that. -
core-ci voted on patch set 4 V -1 11/10/26, 15:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113917
-
Benni Mack updated the commit message in patch set 6 11/10/26, 15:18
-
core-ci voted on patch set 5 V -1 11/10/26, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113918
-
core-ci voted on patch set 6 V +1 11/10/26, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113919
-
Oli Bartsch uploaded patch set 7
V +111/15/26, 10:40 -
core-ci voted on patch set 7 V +1 11/15/26, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114523
-
Oli Bartsch uploaded patch set 8
V +111/15/26, 11:01 -
Oli Bartsch uploaded patch set 9 11/15/26, 11:21
-
core-ci voted on patch set 8 V +1 11/15/26, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114532
-
core-ci voted on patch set 9 V -1 11/15/26, 11:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114538