Review 14.3 Merged

94476[BUGFIX] Use correct index as identifier in UploadedResourceViewHelper

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 06/10/26, 22:21

Commit message

The key in the foreach of an ObjectStorage is not an integer, but the
spl_object_hash of the object. Converting this to an int results in
PHP type juggling random string values like "00005efd0000" to "5". This
leads to exactly the opposite of the intended unique identifier fix from
#109827.

Note: This was revealed by a random functional test job in GitLab CI,
which by chance led to two same identifiers.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 06/10/26, 22:10

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/10/26, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103361

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 06/10/26, 22:21

  4. Christian Kuhn merged patch set 2 06/10/26, 22:21