Review main Ready for review

94510[BUGFIX] Restrict language fallback chain

Maike Kiebele CR -1 V +1 Normal +237 −4 updated 11/13/26, 15:48

Commit message

In strict mode (OVERLAYS_ON/WITH_FLOATING), hidden translated records
were incorrectly falling back to the overlay of a fallback language.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 11
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/10/94510/11 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/10/94510/11 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -1 Needs a vote
    • André Buchmann +1
    • Benni Mack -1
  • Verified V +1 Needs a vote
    • André Buchmann +1
    • core-ci +1 CI

Merge conflicts 3

Issues 1

Files 3

Review log 2132

Show 47 earlier messages
  1. Maike Kiebele uploaded patch set 1 06/15/26, 12:50

  2. core-ci voted on patch set 1 V -1 06/15/26, 13:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103518

  3. Benni Mack commented on patch set 1 06/15/26, 13:15

    hi maike. the issue still is that we need to take ALL of the records, and then actually check with RecordAccessVoter if are visible (hidden, starttime, endtime), I assume. in this case, I would start with a functional test.
  4. Maike Kiebele uploaded patch set 2 V -1 06/17/26, 13:09

  5. core-ci voted on patch set 2 V -1 06/17/26, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103614

  6. Maike Kiebele uploaded patch set 3 V -1 06/17/26, 14:40

  7. core-ci voted on patch set 3 V -1 06/17/26, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103616

  1. Maike Kiebele uploaded patch set 4 V -1 06/22/26, 09:15

  2. Maike Kiebele updated the commit message in patch set 5 06/22/26, 09:24

  3. core-ci voted on patch set 4 V -1 06/22/26, 09:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103734

  4. core-ci voted on patch set 5 V -1 06/22/26, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103735

  5. Maike Kiebele uploaded patch set 6 06/22/26, 09:46

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  6. core-ci voted on patch set 6 V -1 06/22/26, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103736

  7. Maike Kiebele uploaded patch set 7 V -1 08/10/26, 08:51

  8. core-ci voted on patch set 7 V -1 08/10/26, 09:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106265

  9. Maike Kiebele uploaded patch set 8 V -1 08/11/26, 13:53

  10. core-ci voted on patch set 8 V +1 08/11/26, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106442

  11. Benni Mack updated the commit message in patch set 9 V +1 09/23/26, 15:45

  12. Benni Mack rebased onto patch set 10 09/23/26, 15:45

  13. core-ci voted on patch set 9 V +1 09/23/26, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109075

  14. core-ci voted on patch set 10 V +1 09/23/26, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109077

  15. Benni Mack rebased onto patch set 11 V +1 10/12/26, 19:02

  16. Benni Mack commented on patch set 11 CR +1 V +1 10/12/26, 19:02

    Reply

    Done
  17. core-ci voted on patch set 11 V +1 10/12/26, 19:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110923

  18. André Buchmann commented on patch set 11 CR -1 V +1 10/30/26, 11:52

    For fallbackType: strict and fallbackType: free, no fallback should be applied at all. According to Feature #88137 (https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.2/Feature-88137-Multi-levelFallbackForContentInFrontendRendering.html), strict renders only content in the selected language. This patch now incorrectly assumes that strict permits fallback, as explicitly asserted by the new test missingTranslationInStrictModeFallsBackToConfiguredFallbackLanguage(). What do you think @benni@typo3.org ?
  19. Benni Mack voted on patch set 11 CR 0 V 0 11/09/26, 19:14

  20. Benni Mack commented on patch set 11 11/11/26, 11:24

    Reply

    I think we can use this one, to solve all of the problems: https://review.typo3.org/c/Packages/TYPO3.CMS/+/97535
  21. André Buchmann commented on patch set 11 CR +1 11/11/26, 12:30

    Reply

    yes, as pre patch for the other this makes sense.
  22. Martin Clewing commented on patch set 11 11/13/26, 11:33

    Can we please have a changelog entry for this change? As this patch deviates from standard editorial practice, an ‘Important’ changelog entry should be added explaining that, in future, the ‘hidden’ state will immediately cause the element to be hidden in the selected language. As a workaround, ongoing translation processes should therefore be carried out in a workspace. Isn't it a breaking behaviour change? What about elements hidden via access restriction (fe_group) or startime and endtime?
  23. Benni Mack commented on patch set 11 11/13/26, 12:38

    Reply

    yeah, I wonder if we should keep this, or go into another direction - which expects the opposite https://review.typo3.org/c/Packages/TYPO3.CMS/+/97535
  24. Eric Harrer commented on patch set 11 11/13/26, 13:59

    Reply Unresolved

    How can we then explicitly express the intentional absence of content in a language that uses fallback? This patch would make that possible.
  25. Benni Mack commented on patch set 11 CR -1 11/13/26, 15:48

    I need to check if this contradicts other behavior though.