97535[!!!][FEATURE] Introduce site language option "languageMode"
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 5
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/35/97535/5 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/35/97535/5 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 30
- main 97235[BUGFIX] Preview hidden pages across site domains
- main 97553[TASK] Find the descendant pages in the frontend with one query
- main 97455[!!!][FEATURE] Introduce language fallback type "connected"
- main 97436[!!!][FEATURE] Link content elements as records
- main 96845[!!!][TASK] Move Extbase dirty tracking into the persistence layer
- main 94964[!!!][TASK] Remove the extension list import from EM
- main 94510[BUGFIX] Restrict language fallback chain
- main 97555[TASK] Deprecate online media helpers
- main 97241[BUGFIX] Filter Extbase queries by current workspace
- main 93628[WIP][TASK] Make GD the baseline image processor
- main 96941[!!!][FEATURE] Run Extbase action invocation through a middleware stack
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 95162[BUGFIX] Handle empty dates consistently in Extbase
- main 97026[TASK] Reuse parent rootlines for page links
- main 74781[FEATURE] Introduce new slug builders for records and string
- main 96533[WIP][!!!][TASK] Build Extbase persistence on doctrine/orm
- main 88948[!!!][TASK] Refactor Property Handling in AbstractDomainObject
- main 95723[!!!][TASK] Make VisibilityAspect constructor private
- main 92589[TASK] Replace unneeded instanceof on xxx|null. Use a null check instead
- main 95320[TASK] Deprecate package event accessor methods
- main 95308[TASK] Deprecate QueryBuilder::castFieldToTextType()
- main 94780[TASK] Deprecate Site setting typo3Language
- main 94207[FEATURE] Explicit access declaration for backend routes
- main 92249[!!!][TASK] Move content elements to EXT:fluid_styled_content
- main 91423[WIP][TASK] Move config values to both section columns and config
- main 92851[WIP][FEATURE] Allow simplified TCA configuration (Test II)
- main 80554[TASK] Prefer CSP hash values over nonce values
- main 92943[WIP][TASK] Deprecate inline language labels (TYPO3.lang)
- main 91411[WIP][FEATURE] Add support for HEIC and HEIF image formats
- main 85574[WIP][FEATURE] Language-aware slugs and slug normalizer API
Issues 2
Files 38
- typo3/sysext/backend/Classes/Form/FormDataProvider/SiteDatabaseEditRow.php+34 −0
- typo3/sysext/backend/Configuration/SiteConfiguration/site_language.php1+6 −6
- typo3/sysext/backend/Resources/Private/Language/locallang_siteconfiguration_tca.xlf+7 −10
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/SiteDatabaseEditRowTest.php+58 −0
- typo3/sysext/core/Classes/Context/LanguageAspectFactory.php+15 −25
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+40 −25
- typo3/sysext/core/Classes/Site/Entity/SiteLanguage.php+70 −11
- typo3/sysext/core/Classes/Site/LanguageMode.phpnew+37 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-111386-LanguageFallbackTypesConvertedToLanguageMode.rstnew+163 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Deprecation-111386-SiteLanguageOptionFallbackType.rstnew+79 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-111386-IntroduceSiteLanguageOptionLanguageMode.rst1new+236 −0
- typo3/sysext/core/Tests/Functional/Domain/Repository/Fixtures/TranslationFallbackChain.csvnew+19 −0
- typo3/sysext/core/Tests/Functional/Domain/Repository/PageRepositoryLanguageFallbackTest.phpnew+73 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_csv/Configuration/TypoScript/JsonRenderer.typoscript+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield/Configuration/TypoScript/JsonRenderer.typoscript+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Frontend/JsonRenderer.typoscript+1 −1
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedAliasMapperTest.php+3 −3
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedPatternMapperTest.php+3 −3
- typo3/sysext/core/Tests/Functional/SiteHandling/SiteBasedTestTrait.php+19 −12
- typo3/sysext/core/Tests/Unit/Context/LanguageAspectFactoryTest.phpnew+74 −0
Show 18 more files
- typo3/sysext/core/Tests/Unit/Site/Entity/SiteLanguageTest.php+67 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+70 −17
- typo3/sysext/extbase/Tests/Functional/Persistence/BehaviourConformanceTest.php+4 −5
- typo3/sysext/extbase/Tests/Functional/Persistence/QueryIgnoreEnableFieldsTranslationTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/ReadingTranslationsTest.php+5 −12
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslatedSiteContentTest.php+32 −53
- typo3/sysext/extbase/Tests/Functional/Persistence/VisibilityTest.php+13 −13
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+4 −6
- typo3/sysext/frontend/Tests/Functional/Rendering/LocalizedSiteContentRenderingTest.php+75 −124
- typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/ScenarioETest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/ScenarioFTest.php+4 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/TypoLinkGeneratorTest.php+40 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
- typo3/sysext/reports/Classes/Report/Status/SiteConfigurationStatus.phpnew+131 −0
- typo3/sysext/reports/Resources/Private/Language/locallang_reports.xlf+18 −0
- typo3/sysext/reports/Tests/Functional/Report/Status/SiteConfigurationStatusTest.phpnew+54 −0
- typo3/sysext/reports/Tests/Unit/Report/Status/SiteConfigurationStatusTest.phpnew+123 −0
- typo3/sysext/styleguide/Classes/TcaDataGenerator/AbstractGenerator.php+4 −4
Review log 611
-
Benni Mack uploaded patch set 1 11/11/26, 11:02
-
core-ci voted on patch set 1 V -1 11/11/26, 11:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114059
-
Benni Mack rebased onto patch set 2
V -111/13/26, 15:11 -
core-ci voted on patch set 2 V -1 11/13/26, 17:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114352
-
Benni Mack rebased onto patch set 3
V -111/14/26, 11:07 -
core-ci voted on patch set 3 V -1 11/14/26, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114440
-
Benni Mack rebased onto patch set 4
V -111/17/26, 20:05 -
core-ci voted on patch set 4 V -1 11/17/26, 20:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114788
-
Benni Mack uploaded patch set 5
V -111/18/26, 07:06 -
core-ci voted on patch set 5 V +1 11/18/26, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114820
-
André Buchmann commented on patch set 5 11/20/26, 10:33
Feature-111386-IntroduceSiteLanguageOptionLanguageMode.rst:123UnresolvedHidden page translations don't stop the fallback chain. The feature RST says pages, links and menus follow "the rules above". Problem - For records, PageRepository::getRecordOverlay() now selects hidden translations too and stops at the first existing one (RecordAccessVoter). - For pages, PageRepository::getPageOverlaysForLanguage() still excludes hidden translations in the query, so the chain continues. - Example: hidden translation of a page into language 1, fallbacks 0. The page is rendered in the default language, whereas a hidden content element translation is not shown at all. Decision needed - Pages follow the content rule: getPageOverlaysForLanguage() selects hidden translations too and stops at the first existing one. This affects routing, rendering, menus and links together. - Pages keep the current behavior: document the difference in the feature RST and pin it with a test. In addition: The slug of a hidden translation, still resolves. The router matches the hidden translation's slug, then the page overlay skips the hidden translation and renders the default language page under the translation URL.
site_language.php:138Unresolved