Review main Abandoned

94516[BUGFIX] Fix TypeError when importing relation via DataHandler

Benjamin Franzke CR -1 V 0 Easy +4 −2 updated 10/18/26, 07:23

Commit message

Relations (like sys_file_reference when importing EXT:introduction in
v13) may not provide a `pid` value and therefore triggered
a PHP warning and a type error, because `$theRealPid` was
assigned a null value.

Skip the site-resolution, in this case, since the method itself
is meant to skip operation anyway, incase no site could be found.

Review

  • Code review CR -1
    • Benjamin Franzke -1
  • Verified V 0
    • core-ci +1 CI

Issues 3

Files 1

Review log 1012

  1. Benjamin Franzke commented on patch set 1 06/16/26, 08:20

    Cherry Picked from branch 13.4. The following files contain Git conflicts: * typo3/sysext/core/Classes/DataHandling/DataHandler.php
  2. Benjamin Franzke uploaded patch set 2 06/16/26, 08:26

  3. core-ci voted on patch set 1 V -1 06/16/26, 08:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103549

  4. core-ci voted on patch set 2 V +1 06/16/26, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103550

  5. Benjamin Franzke marked it ready for review 06/16/26, 09:39

  6. Benni Mack commented on patch set 2 06/16/26, 11:47

    I have a hard time here... can we somehow create a functional test for this?
  7. Benjamin Franzke commented on patch set 2 06/16/26, 13:09

    Reply Unresolved

    ack, I agree. I'll look into that.
  8. Benjamin Franzke commented on patch set 2 CR -1 06/23/26, 06:23

    DataHandler.php:752

    This is actually a consequential error, that happens because of https://forge.typo3.org/issues/110061 In this case a subpage of another page (that was supposed to be imported, but failed) is missing the "pid" field, because it could not be resolved, in case the import of the parent page failed (e.g. due to database fields not being available) Or in other words: the import of the first page fails because fields provided by EXT:bootstrap_package are not created when it is implicitly installed as a dependency of EXT:introduction. (then again, the first page is not created – which is a silent error only – and this type error is a consequence upon preparing the first subpage) Therefore it is actually not "right" to just "ignore" the missing pid field, since the import will not work anyway, since the destination is effectively missing. => -1 for that reason, maybe we need to log/break/continue in this case explicitly
  9. Benjamin Franzke commented on patch set 2 06/23/26, 12:38

    DataHandler.php:752 Reply Unresolved

    Here a first patch/try to fix the root cause: > 94554: [WIP][BUGFIX] Fix initial introduction package import on sqlite | https://review.typo3.org/c/Packages/TYPO3.CMS/+/94554 Will continue there and come back to this patch later, trying to handle this as a case where data import should fail/be-skipped.
  10. Garvin Hicking marked it work in progress 10/02/26, 12:29

  11. Benni Mack commented on patch set 2 10/13/26, 16:16

    I think we can abandon this issue, because all issues have been resolved differently now
  12. Benni Mack abandoned the change 10/18/26, 07:23

    abandoning the change as commented