Review main Merged

94567[TASK] Harden redirects history rollback processing

Oliver Hader CR +2 V +2 Easy +18 −6 updated 06/25/26, 08:47

Commit message

RecordHistoryRollbackController allows to revert previous
changes to pages concerning slugs of sys_redirect entries.
The rollback process now explicitly checks the ownership of
the correlation collection that shall be rolled back. Besides
that, the request handling has been changed to use HTTP POST.

Note: This change is not classified as a security vulnerability,
since the rollback endpoint only grants exceptional permissions
for sys_redirect; all other table access during rollback still
relies on DataHandler's regular permission checks.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 67

  1. Oliver Hader uploaded patch set 1 06/24/26, 12:16

  2. core-ci voted on patch set 1 V +1 06/24/26, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103813

  3. Oliver Klee voted on patch set 1 CR +1 06/24/26, 14:40

  4. Torben Hansen voted on patch set 1 CR +1 V +1 06/24/26, 16:11

  5. Benjamin Franzke voted on patch set 1 CR +1 V +1 06/25/26, 07:06

  6. Oliver Hader voted on patch set 1 CR +2 V +2 06/25/26, 08:47

  7. Oliver Hader merged patch set 2 06/25/26, 08:47