Review 13.4 Merged

94583[BUGFIX] Guard undefined array key in ImageProcessingInstructions

Garvin Hicking CR +2 V +2 Normal +177 −2 updated 06/26/26, 11:49

Commit message

Even though `ImageProcessingInstructions` is declared internal API,
and the `GraphicalFunctions->resize()` method is too, data passed
to the public method `GraphicslFunctions->imageMagickConvert()`
can pass along `$options` to the image processing instructions.

If these options contain a `['crop' => '']` definition, this
leads to an "undefined array key warning" in the evaluation.

This is now fixed by guarding for an empty string, and also
guarding for a "wrong" string format with a wrong amount
of separating commas now.

Tests to cover more input variants are added to prove the
patch and prevent further regressions.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benjamin Franzke +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benjamin Franzke +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 67

  1. Garvin Hicking commented on patch set 1 06/25/26, 09:52

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/25/26, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103868

  3. Josua Vogel voted on patch set 1 CR +1 V +1 06/25/26, 19:04

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 06/26/26, 09:21

  5. Benjamin Franzke voted on patch set 1 CR +1 V +1 06/26/26, 11:37

  6. Garvin Hicking voted on patch set 1 CR +2 V +2 06/26/26, 11:49

  7. Garvin Hicking merged patch set 2 06/26/26, 11:49