Review 14.3 Merged

94587[TASK] Obtain `ConnectionPool` from container in functional tests

Benjamin Franzke CR +2 V +2 Hard +256 −253 updated 06/26/26, 11:22

Commit message

Avoid using `new ConnectionPool()` to prepare for adding
dependencies to the constructor, wired via the
dependency injection container. Therefore all tests are
adapted to obtain the instance from the container and
the `ConnectionPool` unit tests are moved into the functionals
to avoid mocks and to test in a realistic scenario.

For the sake of preventing future cherry-pick conflicts,
the changes are also backported, although not strictly required.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 25

Show 5 more files

Review log 36

  1. Benjamin Franzke commented on patch set 1 06/26/26, 08:14

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 06/26/26, 09:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103894

  3. core-ci commented on patch set 1 06/26/26, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103894

  4. core-ci voted on patch set 1 V +1 06/26/26, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103894

  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 06/26/26, 11:21

  6. Benjamin Franzke merged patch set 2 06/26/26, 11:22