Review 13.4 Merged

94597[TASK] Prevent PHPUnit warnings on ReflectionService destructor

Benjamin Franzke CR +2 V +2 Easy +9 −1 updated 06/26/26, 20:10

Commit message

Under certain circumstances the PHPUnit functional tests may
call extbase reflection service and keep reflection state around that is
destructed after test execution.

This happened after #108604 added a dependency to the HashService
to the VariableFrontend for caching reflection state.

The reliance on having `$GLOBALS['TYPO3_CONF_VARS']` to exist
for proper destruction fails in instances where these variables
are restored to non-matching states.

This patch adds a hard dependency to the existence of that
variable, so that the data caches will not produce a PHP warning
of missing encryption keys when being called.

Patchset 4 carries an example where this issue surfaces due to
test orders.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 35

  1. Benjamin Franzke commented on patch set 1 06/26/26, 13:10

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 06/26/26, 13:13

  3. core-ci voted on patch set 1 V -1 06/26/26, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103945

  4. core-ci voted on patch set 1 V +1 06/26/26, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103945

  5. Garvin Hicking merged patch set 2 06/26/26, 20:10