Review 13.4 Merged

94609[BUGFIX] List `extension:activate` in list of possible commands

Benjamin Franzke CR +2 V +2 Normal +61 −6 updated 06/29/26, 09:36

Commit message

The list of commands was supposed to skip `extension:activate`
and `extension:deactivate` in composer mode since #94996,
while they should remain visible in classic mode, which fails
for two reasons:

 * The string-based env-expressions – that is
   `hidden: '%env(TYPO3:isComposerMode)%'` in
   `extensionmanager/Configuration/Services.yaml`
   were casted to `bool` by the console command pass, therefore
   they were never evaluated by the symfony `PhpDumper`
   (which operates after the execution of the compiler passes)
 * The expression used an invalid "is" prefix, that was
   implemented differently than it was documented in #89764.
   It implemented support for `%env(TYPO3:composerMode)%`
   but documented `%env(TYPO3:isComposerMode)%`.

We now remove the invalid bool cast and adapt the
env-placeholder implementation to support
the documented behavior, while keeping the
prior implementation intact.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 3

Files 3

Review log 45

  1. Benjamin Franzke commented on patch set 1 06/29/26, 07:39

    Cherry Picked from branch main.
  2. Benjamin Franzke marked it work in progress 06/29/26, 07:40

  3. core-ci voted on patch set 1 V +1 06/29/26, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104013

  4. Benjamin Franzke commented on patch set 1 CR +2 V +2 06/29/26, 09:36

    This change is ready for review.
  5. Benjamin Franzke merged patch set 2 06/29/26, 09:36