94649[TASK] Implement and apply custom PHPStan rule to harden `unserialize`
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
-
Verified V +2 Done
- Garvin Hicking +2
- core-ci +1 CI
Issues 1
Files 14
- Build/phpstan/src/Rules/Classes/UnserializeRule.phpnew+201 −0
- Build/phpstan/phpstan-baseline.neon+0 −12
- Build/phpstan/phpstan.neon+4 −0
- typo3/sysext/core/Classes/Package/Cache/PackageCacheEntry.php+45 −2
- typo3/sysext/core/Classes/Package/PackageManager.php+2 −1
- typo3/sysext/core/Classes/Serializer/AuthenticatedMessageDeserializer.php+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/AST/AstBuilderInterfaceTest.php+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/SysTemplateTreeBuilderTest.php+1 −0
- typo3/sysext/core/Tests/Unit/TypoScript/AST/AstBuilderInterfaceTest.php+1 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+1 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/LazyLoadingProxyTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/LazyObjectStorageTest.php+1 −1
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+1 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −0
Review log 69
-
Garvin Hicking commented on patch set 1 07/01/26, 14:40
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Package/Cache/PackageCacheEntry.php * typo3/sysext/extbase/Tests/Functional/Persistence/LazyLoadingProxyTest.php * typo3/sysext/extbase/Tests/Functional/Persistence/LazyObjectStorageTest.php -
Garvin Hicking commented on patch set 2 07/01/26, 14:44
Published edit on patch set 1. -
core-ci voted on patch set 1 V -1 07/01/26, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104156
-
core-ci voted on patch set 2 V -1 07/01/26, 14:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104157
-
Elias Häußler uploaded patch set 3
V -107/01/26, 15:16 -
core-ci voted on patch set 3 V +1 07/01/26, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104193
-
Garvin Hicking marked it ready for review 07/01/26, 16:42
-
Garvin Hicking voted on patch set 3 CR +2 V +2 07/01/26, 16:44
-
Garvin Hicking merged patch set 4 07/01/26, 16:44