Review 14.3 Merged

94661[TASK] Identify remote packages by key, version and remote

Benni Mack CR +2 V +2 Hard +313 −32 updated 07/08/26, 09:33

Commit message

Whenever the extension manager wanted to download or install a
package from TER, it addressed it by the uid of its row in
tx_extensionmanager_domain_model_extension. This made the whole
download and install flow depend on a package being stored in the
local database first, which stands in the way of browsing a remote
in real-time and installing from it without importing everything
into the database beforehand.

A package is now addressed by what actually identifies it: its
package key, a concrete version and the remote it comes from. A
small PackageIdentifier value object carries this triple, and
ExtensionRepository::findOneByPackageIdentifier() resolves it. The
download and distribution controllers, the download ViewHelper and
the related Fluid templates hand over packageKey, version and remote
instead of the uid, and the download guard in
ExtensionManagementService now looks at the remote a package is
bound to rather than at the presence of a uid.

Nothing changes for the user: resolving still happens against the
database, so the existing behaviour stays the same. The difference
is that a package no longer needs a uid to be downloaded or
installed, which is the groundwork for a real-time remote that does
not populate the database.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 16

Review log 45

  1. Benni Mack commented on patch set 1 07/02/26, 19:40

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/02/26, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104240

  3. Benni Mack voted on patch set 1 CR +2 V +2 07/02/26, 20:16

  4. Benni Mack merged patch set 2 07/02/26, 20:16

  5. Benjamin Franzke wrote 07/08/26, 09:33

    Created a revert of this change as Ib3ab240cbc2f6d7aaefa9e4ac6417aec9f3ad3c7