Review 14.3 Merged

94662[BUGFIX] Fix bulk execute action in scheduler deleting tasks

Benni Mack CR +2 V +2 Easy +17 −9 updated 07/02/26, 22:00

Commit message

Clicking the "Execute selected" button in the scheduler task list
caused one of the selected tasks to be deleted instead of executed.

Two issues combined to produce this:

1. The multi-record-selection action in scheduler.ts appended hidden
   inputs named "execute" and "scheduleCron" to the form, but the
   controller checks parsedBody['action']['execute'] and
   parsedBody['action']['scheduleCron']. The mismatch meant neither
   bulk-action branch was ever entered.

2. The per-task delete/stop mini-forms were nested inside the outer
   multi-record-selection <form>. HTML does not support nested forms;
   browsers ignore the inner <form> tags, making all their hidden
   action[delete] / action[stop] inputs belong to the outer form.
   When the outer form was submitted programmatically for bulk execute,
   those inputs were included, and the controller's elseif chain
   matched the delete branch instead.

Fix: rename the appended inputs to action[execute] and
action[scheduleCron], and move the per-task delete/stop mini-forms
to before the outer multi-record-selection form so they cannot
pollute its submission.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Benni Mack commented on patch set 1 07/02/26, 21:45

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/02/26, 21:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104241

  3. Benni Mack voted on patch set 1 CR +2 V +2 07/02/26, 22:00

  4. Benni Mack merged patch set 2 07/02/26, 22:00