Review 14.3 Merged

94702[TASK] Throw error when DocHeaderComponent has multiple menus

Garvin Hicking CR +2 V +2 Normal +230 −0 updated 07/21/26, 07:52

Commit message

With #107875 the DocHeaderComponent was introduced and featured
streamlined submenu creation.

The assumption was, that backend modules would not contain
multiple DocHeaderComponents next to each other, allowing
to add another level of nesting to a backend module.

This edge case was silently filtered out and resulted in
the unexpected result of only having the first menu
rendered, when in reality the MenuRegistry allowed to
attach multiple menus just fine (for other use cases).

With this patch, the compilation of the DocHeaderComponent
is tightened.

In v15 it now throws an exception hinting at
better not creating nested menu levels, but instead either
using proper submodules, or adding custom dropdown menu
items for functionality. In v14 only a warning will
be logged, giving context to the place where this
occurred.

Given the edge-case scenario and expected rare usage,
this is not considered a breaking change in v15
warranting a changelog entry.

For UI/UX reasons, TYPO3 v14 streamlined the module display
so that only one secondary menu bar is expected.

Missing tests for the DocHeaderComponent and MenuRegistry
are added to fixate the behavior.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 711

  1. Garvin Hicking commented on patch set 1 07/08/26, 06:27

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 07/08/26, 06:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104500

  3. Garvin Hicking uploaded patch set 2 V -1 07/08/26, 07:18

    Adjust backport
  4. core-ci voted on patch set 2 V -1 07/08/26, 07:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104503

  5. Oliver Klee updated the commit message in patch set 3 V -1 07/08/26, 07:42

  6. core-ci voted on patch set 3 V -1 07/08/26, 07:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104507

  7. Garvin Hicking commented on patch set 3 CR -1 07/08/26, 09:33

    Unresolved

    This one needs more work, seems something also changed in v15 for this
  8. Garvin Hicking uploaded patch set 4 CR -1 V -1 07/08/26, 09:44

  9. core-ci voted on patch set 4 V +1 07/08/26, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104512

  10. Garvin Hicking voted on patch set 4 CR +2 V +2 07/21/26, 07:51

  11. Garvin Hicking merged patch set 5 07/21/26, 07:52