Review main Merged

94718[FEATURE] Add language-awareness to EXT:recycler

Garvin Hicking CR +2 V +2 Normal +234 −14 updated 09/01/26, 21:09

Commit message

The backend module for record deletion now also
offers a docHeader dropdown component to change
the language context of the record listing.

The last selected language is remembered via
ModuleData API. The dropdown is only shown
if there are at least two languages available,
keeping this in sync with how the record/layout
listing works.

Additionally, the language icon and name is now
shown inside the recycler record listing for
each record that is language aware and has a language
set (also `-1` is evaluated as `all languages`).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 2534

Show 79 earlier messages
  1. Garvin Hicking uploaded patch set 1 07/09/26, 13:42

  2. Garvin Hicking uploaded patch set 2 07/09/26, 13:42

  3. core-ci voted on patch set 1 V +1 07/09/26, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104571

  4. core-ci voted on patch set 2 V +1 07/09/26, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104572

  5. Simon Schaufelberger commented on patch set 2 07/09/26, 14:44

    RecyclerAjaxController.php:69

    use ternary

    RecyclerModuleController.php:70

    this could be simplified with a ternary expression

    RecyclerModuleController.php:154

    use ternary
  6. Garvin Hicking commented on patch set 2 07/09/26, 14:50

    RecyclerAjaxController.php:69 Reply

    Tell me how, because I cannot use (int) for null

    RecyclerModuleController.php:70 Reply

    see above, happy for a solution that remains with low cognitive load and no margin for an error causing null=>0 conversion

    RecyclerModuleController.php:154 Reply

    See above above
  7. Andreas Kienast commented on patch set 2 07/10/26, 05:08

    RecyclerAjaxController.php:69 Reply

    What about ``` $languageId = $submittedLanguageId !== null ? (int)$submittedLanguageId : null; ```

    RecyclerModuleController.php:70 Reply

    What about ``` $languageId = $id > 0 ? $this->addLanguageSwitcher($request, $backendUser, $view, $id) : null; ```

    RecyclerModuleController.php:154 Reply

    What about ``` $languageId = $submittedLanguageId !== null ? (int)$submittedLanguageId : null; ```
  8. Garvin Hicking commented on patch set 2 07/10/26, 05:37

    RecyclerModuleController.php:154 Reply

    Sounds great to me, thanks! My mind was blocked 🤪
  9. Garvin Hicking commented on patch set 3 V +1 07/10/26, 14:31

    Published edit on patch set 2.
  1. core-ci voted on patch set 3 V +1 07/10/26, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104636

  2. Garvin Hicking commented on patch set 3 07/10/26, 15:35

    RecyclerAjaxController.php:69 Reply

    Done

    RecyclerModuleController.php:70 Reply

    Done

    RecyclerModuleController.php:154 Reply

    Done
  3. Simon Schaufelberger voted on patch set 3 CR +1 V +1 07/10/26, 15:41

  4. Daniel Siepmann commented on patch set 3 V +1 07/15/26, 07:53

    It works as expected, thanks for implementing my feature request. One thing though: I'd expect the language selection to be persisted. A use case: I switch to a recycler on page a, limit to language English. I than see that the actual records are on a subpage and switch to that subpage. Now the language is lost and I've to re-select the language. I've checked the records module, this persists the language slection, probably through the module data api? https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Backend/BackendModules/ModuleDataObject.html Still +1 as it already works and is a huge improvement.
  5. Garvin Hicking uploaded patch set 4 CR +1 V +1 07/17/26, 13:56

  6. core-ci voted on patch set 4 V +1 07/17/26, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104882

  7. Garvin Hicking commented on patch set 4 07/17/26, 22:40

    Reply

    Imolemented the persistence part now, too.
  8. Daniel Siepmann commented on patch set 4 V +1 07/20/26, 05:18

    Reply

    Thanks, it is working. I've also testes a multi site setup where one site does not have the language which was selected last. Right now the recycler does not show any deleted record, not a language in the selector. Not sure if that's the expected. The history module does not have the issue, as it is only available through a right click and always uses the language of the corresponding record? So I've no comparison. The "Layout" and "Records" module also hide the language selector if only a single language is available. Still +1 from me as it works and is a huge improvement already. The "complains" are only minor issues for power users and no blocker from a user perspective.
  9. Garvin Hicking uploaded patch set 5 V +1 07/21/26, 06:49

  10. Garvin Hicking commented on patch set 5 07/21/26, 06:50

    Reply

    Thanks! Very valid, I've shuffled this around so often that I forgot to re-address this. Should work now? :)
  11. core-ci voted on patch set 5 V +1 07/21/26, 06:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105072

  12. Garvin Hicking uploaded patch set 6 V +1 07/21/26, 07:49

  13. Garvin Hicking uploaded patch set 7 07/21/26, 08:00

  14. Daniel Siepmann voted on patch set 7 V +1 07/21/26, 08:05

  15. core-ci voted on patch set 6 V +1 07/21/26, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105081

  16. Daniel Siepmann commented on patch set 7 07/21/26, 08:10

    I've tested the following: - Open the recycler module on a multi language page - Switch to Language "English" - Switch to a page with only a single language - Switch to a page with 2 languages but not "English"
  17. core-ci voted on patch set 7 V +1 07/21/26, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105085

  18. Josua Vogel uploaded patch set 8 V +1 07/28/26, 14:28

  19. core-ci voted on patch set 8 V +1 07/28/26, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105547

  20. Josua Vogel commented on patch set 8 07/28/26, 14:46

    For the record: I fixed the ajax action (filter) to respect the language
  21. Garvin Hicking uploaded patch set 9 V +1 07/28/26, 18:14

  22. core-ci voted on patch set 9 V +1 07/28/26, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105551

  23. Josua Vogel voted on patch set 9 CR +1 V +1 07/29/26, 08:40

  24. Benni Mack voted on patch set 9 CR +2 V +2 09/01/26, 21:09

  25. Benni Mack merged patch set 10 09/01/26, 21:09