94718[FEATURE] Add language-awareness to EXT:recycler
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josua Vogel +1
-
Verified V +2 Done
- Benni Mack +2
- Josua Vogel +1
- core-ci +1 CI
Issues 1
Files 10
- Build/Sources/TypeScript/recycler/recycler.ts+6 −0
- Build/types/TYPO3/index.d.ts+1 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-107345-RecyclerLanguageFilter.rstnew+42 −0
- typo3/sysext/recycler/Classes/Controller/RecyclerAjaxController.php4+8 −2
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php9+90 −2
- typo3/sysext/recycler/Classes/Domain/Model/DeletedRecords.php+23 −4
- typo3/sysext/recycler/Classes/Service/RecyclerService.php+56 −4
- typo3/sysext/recycler/Configuration/Backend/Modules.php+1 −0
- typo3/sysext/recycler/Resources/Private/Partials/RecordsTable/DeletedRecord.fluid.html+6 −1
- typo3/sysext/recycler/Resources/Public/JavaScript/recycler.js+1 −1
Review log 2534
Show 79 earlier messages
-
Garvin Hicking uploaded patch set 1 07/09/26, 13:42
-
Garvin Hicking uploaded patch set 2 07/09/26, 13:42
-
core-ci voted on patch set 1 V +1 07/09/26, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104571
-
core-ci voted on patch set 2 V +1 07/09/26, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104572
-
Simon Schaufelberger commented on patch set 2 07/09/26, 14:44
RecyclerModuleController.php:70this could be simplified with a ternary expressionRecyclerModuleController.php:154use ternary -
Garvin Hicking commented on patch set 2 07/09/26, 14:50
RecyclerAjaxController.php:69ReplyTell me how, because I cannot use (int) for nullRecyclerModuleController.php:70Replysee above, happy for a solution that remains with low cognitive load and no margin for an error causing null=>0 conversionRecyclerModuleController.php:154ReplySee above above -
Andreas Kienast commented on patch set 2 07/10/26, 05:08
RecyclerAjaxController.php:69ReplyWhat about ``` $languageId = $submittedLanguageId !== null ? (int)$submittedLanguageId : null; ```RecyclerModuleController.php:70ReplyWhat about ``` $languageId = $id > 0 ? $this->addLanguageSwitcher($request, $backendUser, $view, $id) : null; ```RecyclerModuleController.php:154ReplyWhat about ``` $languageId = $submittedLanguageId !== null ? (int)$submittedLanguageId : null; ``` -
Garvin Hicking commented on patch set 2 07/10/26, 05:37
RecyclerModuleController.php:154ReplySounds great to me, thanks! My mind was blocked 🤪 -
Garvin Hicking commented on patch set 3
V +107/10/26, 14:31Published edit on patch set 2.
-
core-ci voted on patch set 3 V +1 07/10/26, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104636
-
Garvin Hicking commented on patch set 3 07/10/26, 15:35
RecyclerAjaxController.php:69ReplyDoneRecyclerModuleController.php:70ReplyDoneRecyclerModuleController.php:154ReplyDone -
Simon Schaufelberger voted on patch set 3 CR +1 V +1 07/10/26, 15:41
-
Daniel Siepmann commented on patch set 3 V +1 07/15/26, 07:53
It works as expected, thanks for implementing my feature request. One thing though: I'd expect the language selection to be persisted. A use case: I switch to a recycler on page a, limit to language English. I than see that the actual records are on a subpage and switch to that subpage. Now the language is lost and I've to re-select the language. I've checked the records module, this persists the language slection, probably through the module data api? https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Backend/BackendModules/ModuleDataObject.html Still +1 as it already works and is a huge improvement. -
Garvin Hicking uploaded patch set 4
CR +1V +107/17/26, 13:56 -
core-ci voted on patch set 4 V +1 07/17/26, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104882
-
Garvin Hicking commented on patch set 4 07/17/26, 22:40
Reply
Imolemented the persistence part now, too. -
Daniel Siepmann commented on patch set 4 V +1 07/20/26, 05:18
Reply
Thanks, it is working. I've also testes a multi site setup where one site does not have the language which was selected last. Right now the recycler does not show any deleted record, not a language in the selector. Not sure if that's the expected. The history module does not have the issue, as it is only available through a right click and always uses the language of the corresponding record? So I've no comparison. The "Layout" and "Records" module also hide the language selector if only a single language is available. Still +1 from me as it works and is a huge improvement already. The "complains" are only minor issues for power users and no blocker from a user perspective. -
Garvin Hicking uploaded patch set 5
V +107/21/26, 06:49 -
Garvin Hicking commented on patch set 5 07/21/26, 06:50
Reply
Thanks! Very valid, I've shuffled this around so often that I forgot to re-address this. Should work now? :) -
core-ci voted on patch set 5 V +1 07/21/26, 06:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105072
-
Garvin Hicking uploaded patch set 6
V +107/21/26, 07:49 -
Garvin Hicking uploaded patch set 7 07/21/26, 08:00
-
Daniel Siepmann voted on patch set 7 V +1 07/21/26, 08:05
-
core-ci voted on patch set 6 V +1 07/21/26, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105081
-
Daniel Siepmann commented on patch set 7 07/21/26, 08:10
I've tested the following: - Open the recycler module on a multi language page - Switch to Language "English" - Switch to a page with only a single language - Switch to a page with 2 languages but not "English" -
core-ci voted on patch set 7 V +1 07/21/26, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105085
-
Josua Vogel uploaded patch set 8
V +107/28/26, 14:28 -
core-ci voted on patch set 8 V +1 07/28/26, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105547
-
Josua Vogel commented on patch set 8 07/28/26, 14:46
For the record: I fixed the ajax action (filter) to respect the language -
Garvin Hicking uploaded patch set 9
V +107/28/26, 18:14 -
core-ci voted on patch set 9 V +1 07/28/26, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105551
-
Josua Vogel voted on patch set 9 CR +1 V +1 07/29/26, 08:40
-
Benni Mack voted on patch set 9 CR +2 V +2 09/01/26, 21:09
-
Benni Mack merged patch set 10 09/01/26, 21:09
RecyclerAjaxController.php:69