Review 12.4 Abandoned

94723[TASK] Prevent PHPUnit warnings on ReflectionService destructor

Helmut Hummel CR 0 V 0 Easy +9 −1 updated 07/10/26, 10:53

Commit message

Under certain circumstances the PHPUnit functional tests may
call extbase reflection service and keep reflection state around that is
destructed after test execution.

This happened after #108604 added a dependency to the HashService
to the VariableFrontend for caching reflection state.

The reliance on having `$GLOBALS['TYPO3_CONF_VARS']` to exist
for proper destruction fails in instances where these variables
are restored to non-matching states.

This patch adds a hard dependency to the existence of that
variable, so that the data caches will not produce a PHP warning
of missing encryption keys when being called.

Patchset 4 carries an example where this issue surfaces due to
test orders.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 2

  1. Helmut Hummel commented on patch set 1 07/10/26, 10:53

    Cherry Picked from branch main.
  2. Helmut Hummel abandoned the change 07/10/26, 10:53

    only for ELTS