Review 14.3 Merged

94899[BUGFIX] Evaluate sortDesc parameter correctly in indexed_search

Benni Mack CR +2 V +2 Easy +2 −3 updated 07/23/26, 11:54

Commit message

The IndexedSearchRepository method getDescendingSortOrderFlag()
wrongly returned descending order ('DESC') when sortDesc was 0,
and an empty string (defaulting to 'ASC') when sortDesc was 1.

The logic is now corrected:
- If sortDesc is 1, sort order is 'DESC'.
- Otherwise, sort order defaults to 'ASC'.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 07/23/26, 11:04

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/23/26, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105235

  3. Benni Mack voted on patch set 1 CR +2 V +2 07/23/26, 11:54

  4. Benni Mack merged patch set 2 07/23/26, 11:54