Review main Abandoned

94917[BUGFIX] Fix free and mixed mode language comparison

Denis Mir CR 0 V 0 Hard +408 −67 updated 08/27/26, 09:33

Commit message

The Layout module binds translations to the default language rows
(#106649). In free translation mode (l18n_parent = 0) that binding has
no target, so free-mode content collapsed into the first default row
and was hidden when the default column was empty.

The comparison grid now distinguishes the translation modes:

* Connected translations stay in the same row as their default
  language parent.
* Free-mode content of a language that also has connected translations
  is inserted as its own row at its sorting position.
* A comparison that contains only free-mode languages renders each
  language as an independent column per colPos.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 4

Files 4

Review log 913

  1. Denis Mir uploaded patch set 1 07/24/26, 05:02

  2. core-ci voted on patch set 1 V +1 07/24/26, 05:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105288

  3. Denis Mir uploaded patch set 2 V +1 07/24/26, 07:30

  4. core-ci voted on patch set 2 V +1 07/24/26, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105298

  5. Benni Mack updated the commit message in patch set 3 V +1 07/24/26, 07:43

  6. core-ci voted on patch set 3 V +1 07/24/26, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105300

  7. Eric Harrer commented on patch set 3 07/24/26, 15:09

    Results of today’s translation handling meeting: The patch improves pure Free Mode views, but currently breaks combined views containing both Connected and Free Mode languages. The default language binding intended by [#106649](https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/14.0/Important-106649-DefaultLanguageBindingInPageModule.html#important-106649-1746479411) is lost for connected translations in combined views. Connected elements must remain aligned with their default-language parents, while Free Mode elements require independent handling. Both concepts also need to work together in Mixed Mode.
  8. Denis Mir uploaded patch set 4 V +1 07/28/26, 06:40

  9. core-ci voted on patch set 4 V +1 07/28/26, 06:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105522

  10. Eric Harrer commented on patch set 4 08/09/26, 12:48

    Reply

    This has been resolved. Thanks!
    Thanks to this patch, we were able to establish a clear objective during T3DD26 and use it as the basis for implementing a less invasive, Fluid-only variant. Therefore, I think this patch should now be abandoned in favour of the new approach: https://review.typo3.org/c/Packages/TYPO3.CMS/+/95178
  11. Eric Harrer commented on patch set 4 08/09/26, 12:52

    Reply

    Sorry, in my last comment I accidentally mentioned the wrong patch (somewhat related). I actually meant the patch at https://review.typo3.org/c/Packages/TYPO3.CMS/+/95170
  12. Eric Harrer commented on patch set 4 08/14/26, 15:45

    Reply Unresolved

    This patch can now safely be marked as ‘abandoned’, as https://review.typo3.org/c/Packages/TYPO3.CMS/+/95170 has now been merged and resolves exactly the same issue.
  13. Denis Mir abandoned the change 08/27/26, 09:33