94917[BUGFIX] Fix free and mixed mode language comparison
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 4
- Bug #110275Free-mode language columns are misaligned by forced default-language binding in the Layout module
- Bug #109963Problem with language comparison in free mode and defLangBinding
- Task #106649Make mod.defLangBinding = 1 the default
- Bug #108809Free-mode content not shown in Language Comparison Mode when default language is empty
Files 4
- typo3/sysext/backend/Classes/View/Drawing/BackendLayoutRenderer.php+144 −21
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.fluid.html+42 −46
- typo3/sysext/backend/Tests/Functional/View/Drawing/BackendLayoutRendererFreeModeComparisonTest.phpnew+183 −0
- typo3/sysext/backend/Tests/Functional/View/Fixtures/FreeModeGridComparisonScenario.yamlnew+39 −0
Review log 913
-
Denis Mir uploaded patch set 1 07/24/26, 05:02
-
core-ci voted on patch set 1 V +1 07/24/26, 05:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105288
-
Denis Mir uploaded patch set 2
V +107/24/26, 07:30 -
core-ci voted on patch set 2 V +1 07/24/26, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105298
-
Benni Mack updated the commit message in patch set 3
V +107/24/26, 07:43 -
core-ci voted on patch set 3 V +1 07/24/26, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105300
-
Eric Harrer commented on patch set 3 07/24/26, 15:09
Results of today’s translation handling meeting: The patch improves pure Free Mode views, but currently breaks combined views containing both Connected and Free Mode languages. The default language binding intended by [#106649](https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/14.0/Important-106649-DefaultLanguageBindingInPageModule.html#important-106649-1746479411) is lost for connected translations in combined views. Connected elements must remain aligned with their default-language parents, while Free Mode elements require independent handling. Both concepts also need to work together in Mixed Mode. -
Denis Mir uploaded patch set 4
V +107/28/26, 06:40 -
core-ci voted on patch set 4 V +1 07/28/26, 06:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105522
-
Eric Harrer commented on patch set 4 08/09/26, 12:48
Reply
This has been resolved. Thanks!Thanks to this patch, we were able to establish a clear objective during T3DD26 and use it as the basis for implementing a less invasive, Fluid-only variant. Therefore, I think this patch should now be abandoned in favour of the new approach: https://review.typo3.org/c/Packages/TYPO3.CMS/+/95178 -
Eric Harrer commented on patch set 4 08/09/26, 12:52
Reply
Sorry, in my last comment I accidentally mentioned the wrong patch (somewhat related). I actually meant the patch at https://review.typo3.org/c/Packages/TYPO3.CMS/+/95170 -
Eric Harrer commented on patch set 4 08/14/26, 15:45
Reply Unresolved
This patch can now safely be marked as ‘abandoned’, as https://review.typo3.org/c/Packages/TYPO3.CMS/+/95170 has now been merged and resolves exactly the same issue. -
Denis Mir abandoned the change 08/27/26, 09:33