Review 14.3 Merged

94927[BUGFIX] Hand correlationId over to sub instances of DataHandler

Benni Mack CR +2 V +2 Normal +101 −28 updated 07/24/26, 14:02

Commit message

A single logical editor action frequently spawns nested DataHandler
instances internally: copying a page copies its content elements via
sub instances, localizing records processes child commands through a
separate DataHandler in DataMapProcessor, and workspace auto-versioning
as well as cascading deletes of related records do the same.

Since DataHandler::start() unconditionally generated a fresh
correlation id per instance, the sys_history entries of one and the
same operation were scattered across several unrelated correlation
scopes. As a result, any functionality resolving an operation via
RecordHistory::findEventsForCorrelation() - such as the rollback of
redirects - only saw the changes made by the outermost
instance and silently missed everything written by sub instances.

DataHandler::start() now accepts an optional CorrelationId which all
internal sub instance call sites (including DataMapProcessor) pass
down the chain, mirroring the existing ReferenceIndexUpdater
pass-through. All history entries of one logical operation therefore
share the correlation scope of the outermost instance, making the
operation traceable and revertable as a whole.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 34

  1. Benni Mack commented on patch set 1 07/24/26, 13:49

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/24/26, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105318

  3. Benni Mack voted on patch set 1 CR +2 V +2 07/24/26, 14:02

  4. Benni Mack merged patch set 2 07/24/26, 14:02