Review main Merged

94944[TASK] Prepare tests for PHPUnit 13

Wouter Wolters CR +2 V +2 Hard +356 −317 updated 07/29/26, 07:56

Commit message

Apply PHPUnit 13-compatible mock expectations, redundant matcher
removals and data-provider signatures while keeping PHPUnit 11.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 80

Show 60 more files

Review log 1317

  1. Wouter Wolters uploaded patch set 1 07/25/26, 08:50

  2. Wouter Wolters uploaded patch set 2 07/25/26, 08:56

  3. Wouter Wolters marked it ready for review 07/25/26, 08:57

  4. core-ci voted on patch set 1 V -1 07/25/26, 08:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105387

  5. core-ci voted on patch set 2 V -1 07/25/26, 09:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105388

  6. Wouter Wolters marked it work in progress 07/25/26, 09:11

  7. Wouter Wolters uploaded patch set 3 V -1 07/25/26, 09:12

  8. Wouter Wolters marked it ready for review 07/25/26, 09:13

  9. core-ci voted on patch set 3 V +1 07/25/26, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105389

  10. Oliver Klee commented on patch set 3 V +1 07/25/26, 09:35

    ListenerProviderTest.php:76

    We can replace all `$this->atLeast(1)` with `$this->atLeastOnce()`.
  11. Wouter Wolters uploaded patch set 4 V +1 07/25/26, 10:09

  12. Wouter Wolters commented on patch set 3 07/25/26, 10:10

    ListenerProviderTest.php:76 Reply

    Done
  13. core-ci voted on patch set 4 V +1 07/25/26, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105390

  14. Oliver Klee voted on patch set 4 CR +1 V +1 07/25/26, 11:30

  15. Garvin Hicking voted on patch set 4 CR +1 V +1 07/28/26, 15:14

  16. Benni Mack voted on patch set 4 CR +2 V +2 07/29/26, 07:56

  17. Benni Mack merged patch set 5 07/29/26, 07:56