Review 14.3 Merged

94977[TASK] Have playwright helper middleware authenticate requests

Garvin Hicking CR +2 V +2 Normal +53 −11 updated 07/29/26, 07:38

Commit message

The playwright middleware added with the migrated install tool
tests in #109761 raised concerns since the test instance is
exposed as local port.

The patch adds a secret – available to the middleware and
playwright – that is sent as HTTP header and verified in
the middleware.

This patch was initially created as [1] by Christian Kuhn.

[1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/93984

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 56

  1. Garvin Hicking commented on patch set 1 07/29/26, 07:27

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/tests/packages/playwright_helper/Classes/Middleware/PlaywrightHelperMiddleware.php
  2. Garvin Hicking commented on patch set 2 07/29/26, 07:27

    Published edit on patch set 1.
  3. Garvin Hicking marked it ready for review 07/29/26, 07:27

  4. core-ci voted on patch set 2 V +1 07/29/26, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105570

  5. Garvin Hicking voted on patch set 2 CR +2 V +2 07/29/26, 07:38

  6. Garvin Hicking merged patch set 3 07/29/26, 07:38