Review 14.3 Merged

94978[BUGFIX] Avoid TypeError for IMAGE cObject with missing file

Garvin Hicking CR +2 V +2 Normal +62 −7 updated 07/29/26, 09:54

Commit message

When an IMAGE content object references a FAL file whose
physical file has been deleted (sys_file.missing=1),
ImageResource::getPublicUrl() returns null and cImage()
passes it to AssetCollector::addMedia(), which requires a
string. The TypeError aborts the whole page rendering.

Treat a null public URL like an unresolvable image resource
and return an empty string, as the method already does when
getImgResource() returns null. This restores the behavior
of v12 and earlier.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Garvin Hicking commented on patch set 1 07/29/26, 07:59

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/29/26, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105571

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 07/29/26, 09:54

  4. Garvin Hicking merged patch set 2 07/29/26, 09:54