Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
95027[!!!][FEATURE] Allow a mail profile per site
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/27/95027/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/27/95027/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 2
-
95027 [!!!][FEATURE] Allow a mail profile per site This change
-
main
95026[FEATURE] Add named mail profiles
The chain has patch set 2 of 6, the changes above it need a rebase.
Issues 2
Files 12
- typo3/sysext/core/Classes/Mail/MailerFactory.php+24 −0
- typo3/sysext/core/Classes/Mail/MailProfileResolver.php+26 −0
- typo3/sysext/core/Configuration/Sets/Email/labels.xlf+6 −0
- typo3/sysext/core/Configuration/Sets/Email/settings.definitions.yaml+4 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-107307-EmailFinisherReceivesMailerFactory.rstnew+50 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-107307-MailProfilePerSite.rstnew+70 −0
- typo3/sysext/core/Tests/Unit/Mail/MailerFactoryTest.php+24 −1
- typo3/sysext/core/Tests/Unit/Mail/MailProfileResolverTest.php+30 −1
- typo3/sysext/felogin/Classes/Service/RecoveryService.php+3 −3
- typo3/sysext/felogin/Tests/Unit/Service/RecoveryServiceTest.php+4 −1
- typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php+3 −3
- typo3/sysext/form/Tests/Functional/Domain/Finishers/EmailFinisherTest.php+8 −7
Review log 57
-
Benni Mack uploaded patch set 1 07/30/26, 20:12
-
core-ci voted on patch set 1 V +1 07/30/26, 20:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105713
-
Oliver Klee voted on patch set 1 V +1 08/02/26, 08:53
-
Radostin Milenov commented on patch set 1 09/14/26, 05:08
I do have a queston to ask. Would it be beyong reason to actually let the mailer fail gracefully if there isn't a config for one speicifc site? Atleast in the form of a feature toggle for example. I could imagine in some cases it might actually be preffered to sending the mail from the wrong address. -
Benni Mack uploaded patch set 2
V +111/13/26, 18:01 -
Benni Mack commented on patch set 2 11/13/26, 18:04
Reply
The fallback is deliberate, so a renamed profile doesn't break a site's emails. A strict mode could be a follow-up. -
core-ci voted on patch set 2 V +1 11/13/26, 19:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114367