Review main Merged

95060[TASK] Use FAL API directly in image ViewHelpers

Benni Mack CR +2 V +2 Normal +46 −19 updated 08/02/26, 12:25

Commit message

The image related ViewHelpers went through Extbase's ImageService for
two operations that no longer need a service: applying processing
instructions, which is a one line delegation to File->process() since
FileReference->process() exists, and resolving the public URL, which
is File->getPublicUrl() plus an optional absolutization.

Both are now done directly. As a result f:media, f:image.srcset and
the SEO MetaTagGenerator no longer depend on ImageService at all;
f:image and f:uri.image keep it only to resolve the "src" argument.

The absolutization prefers the request from the rendering context and
falls back to $GLOBALS['TYPO3_REQUEST'], which is what ImageService
used. Rendering contexts are not guaranteed to carry a request, so the
fallback is kept for now.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 67

  1. Benni Mack uploaded patch set 1 08/02/26, 08:46

  2. Benni Mack marked it ready for review 08/02/26, 08:47

  3. core-ci voted on patch set 1 V +1 08/02/26, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105832

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 08/02/26, 09:33

  5. Stefan Bürk voted on patch set 1 CR +1 V +1 08/02/26, 12:16

  6. Stefan Bürk voted on patch set 1 CR +2 V +2 08/02/26, 12:25

  7. Stefan Bürk merged patch set 2 08/02/26, 12:25