Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
95067[BUGFIX] Cache busting for images rendered by Fluid
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 4
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/67/95067/4 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/67/95067/4 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -2 Blocked
- Helmut Hummel -2
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 4
Files 41
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListCopyToClipboard.php+2 −2
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTableCopyToClipboard.php+2 −2
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArgumentsCopyToClipboard.php+2 −2
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+18 −1
- typo3/sysext/core/Classes/SystemResource/Http/CacheBustingUri.php2+35 −4
- typo3/sysext/core/Documentation/Changelog/15.0/Important-105403-CacheBustingForUnalteredImagesInFluidViewHelpers.rstnew+105 −0
- typo3/sysext/core/Tests/Functional/Imaging/IconProvider/BitmapIconProviderTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Imaging/IconProvider/SvgIconProviderTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Imaging/IconProvider/SvgSpriteIconProviderTest.php+8 −8
- typo3/sysext/core/Tests/Functional/Mail/FluidEmailTest.php+12 −3
- typo3/sysext/core/Tests/Functional/Page/AssetRendererTest.php+14 −14
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+16 −16
- typo3/sysext/core/Tests/Functional/SystemResource/Publishing/DefaultResourcePublisherTest.php+17 −17
- typo3/sysext/core/Tests/Functional/ViewHelpers/IconViewHelperTest.php+1 −1
- typo3/sysext/core/Tests/Unit/SystemResource/Http/CacheBustingUriTest.php+49 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Image/SrcsetViewHelper.php+5 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ImageViewHelper.php+5 −0
- typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php+3 −0
- typo3/sysext/fluid/Classes/ViewHelpers/MediaViewHelper.php+5 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ImageViewHelperTest.php+8 −8
Show 21 more files
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageConvertGMViewHelperTest.php+32 −32
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageConvertIMViewHelperTest.php+35 −35
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageViewHelperTest.php+68 −26
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/MediaViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/SvgImageViewHelperTest.php+5 −5
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/DataProcessing/FlexFormProcessorTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/Rendering/AbsoluteUriPrefixRenderingTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/Rendering/ScriptAndLinkTagRenderingTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php+4 −4
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportPageAndRecords.php+25 −25
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportPageAndRecordsWithSoftRefs.php+17 −17
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportRecords.php+5 −5
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportTable.php+9 −9
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecords.php+12 −12
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsByUpdate.php+8 −8
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsByUpdateWithDiff.php+28 −28
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsWithDiff.php+28 −28
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsWithSoftRefs.php+6 −6
- typo3/sysext/rte_ckeditor/Tests/Functional/Form/Element/RichTextElementTest.php+4 −4
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapXslTest.php+1 −1
Review log 1012
-
Benjamin Kott uploaded patch set 1 08/02/26, 14:35
-
Benjamin Kott uploaded patch set 2 08/02/26, 17:24
-
Benjamin Kott wrote 08/26/26, 07:25
Unset private -
Benjamin Kott uploaded patch set 3 08/26/26, 07:55
-
core-ci voted on patch set 3 V -1 08/26/26, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107128
-
Andreas Kienast uploaded patch set 4
V -108/26/26, 08:11 -
core-ci voted on patch set 4 V +1 08/26/26, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107129
-
Helmut Hummel commented on patch set 4 CR -1 09/03/26, 11:59
I'm not to convinced about the currently suggested implementation. I try to make a different suggestion, as cache busting is already covered by resources APICacheBustingUri.php:31UnresolvedThis comment is meant as is. This class should remain internal to system resources -
Helmut Hummel commented on patch set 4 CR -2 09/03/26, 12:07
I can't come up with a different suggestion until the question about the cache busting is answered. I will therefore block this until we clarify the demands.CacheBustingUri.php:90UnresolvedWhy is the existing cache busting replaced with a different one? -
Helmut Hummel commented on patch set 4 09/04/26, 09:54
Unresolved
here is an alternative that solves exactly one thing (cache busting for images rendered by Fluid): https://review.typo3.org/c/Packages/TYPO3.CMS/+/95636 -
Helmut Hummel marked it work in progress 09/04/26, 09:54
-
Benni Mack commented on patch set 4 11/15/26, 07:39
Is this an alternative? https://review.typo3.org/c/Packages/TYPO3.CMS/+/97627