Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
95105[TASK] Apply PHP code simplifications
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 6
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/05/95105/6 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/05/95105/6 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 2
-
main
95106[TASK] Remove unused PHP imports
The chain has patch set 1 of 2, the changes above it need a rebase.
-
95105 [TASK] Apply PHP code simplifications This change
Issues 1
Files 109
- typo3/sysext/backend/Classes/Backend/Bookmark/BookmarkService.php+1 −3
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php+1 −2
- typo3/sysext/backend/Classes/ContextMenu/ContextMenu.php+0 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php2+4 −4
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php+1 −3
- typo3/sysext/backend/Classes/Controller/RecordListController.php+1 −2
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+2 −2
- typo3/sysext/backend/Classes/Form/Container/FlexFormContainerContainer.php+1 −3
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+1 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabasePageLanguageOverlayRows.php+1 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRowInitializeNew.php+1 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/EvaluateDisplayConditions.php+1 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaColumnsProcessFieldDescriptions.php+1 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaColumnsProcessFieldLabels.php+1 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexProcess.php+2 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php+1 −2
- typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php+2 −4
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+1 −3
- typo3/sysext/backend/Classes/Routing/PreviewUriBuilder.php+1 −3
- typo3/sysext/backend/Classes/Tree/TreeRepresentationNode.php+1 −2
Show 89 more files
- typo3/sysext/backend/Tests/Functional/Controller/RecordListControllerTest.php+1 −3
- typo3/sysext/backend/Tests/Unit/Search/Event/BeforeLiveSearchFormIsBuiltEventTest.php+1 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php6+2 −3
- typo3/sysext/core/Classes/Cache/Frontend/AbstractFrontend.php+0 −1
- typo3/sysext/core/Classes/Configuration/Tca/TcaEnrichment.php+1 −2
- typo3/sysext/core/Classes/Configuration/Tca/TcaMigration.php1+1 −3
- typo3/sysext/core/Classes/Configuration/Tca/TcaPreparation.php1+1 −2
- typo3/sysext/core/Classes/Configuration/Richtext.php+1 −1
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php+1 −2
- typo3/sysext/core/Classes/Database/Schema/SchemaMigrator.php+1 −3
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapItem.php+1 −2
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+3 −3
- typo3/sysext/core/Classes/DataHandling/PlainDataResolver.php+1 −2
- typo3/sysext/core/Classes/Domain/Persistence/GreedyDatabaseBackend.php+1 −2
- typo3/sysext/core/Classes/Html/HtmlParser.php+2 −3
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+12 −14
- typo3/sysext/core/Classes/LinkHandling/LegacyLinkNotationConverter.php+2 −2
- typo3/sysext/core/Classes/LinkHandling/PageTypeLinkResolver.php+1 −2
- typo3/sysext/core/Classes/Localization/LabelFileResolver.php+2 −5
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php+1 −2
- typo3/sysext/core/Classes/Locking/FileLockStrategy.php+1 −3
- typo3/sysext/core/Classes/Log/LogRecord.php+1 −2
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/AbstractOnlineMediaHelper.php+1 −2
- typo3/sysext/core/Classes/Resource/Processing/LocalImageProcessor.php+1 −1
- typo3/sysext/core/Classes/Resource/Rendering/YouTubeRenderer.php+1 −3
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+1 −2
- typo3/sysext/core/Classes/Routing/Aspect/StaticRangeMapper.php+1 −2
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/Configuration/DispositionConfiguration.php+1 −3
- typo3/sysext/core/Classes/Service/MarkerBasedTemplateService.php+1 −3
- typo3/sysext/core/Classes/Service/UpgradeWizardsService.php+1 −3
- typo3/sysext/core/Classes/Slug/SlugNormalizer.php+1 −3
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+0 −2
- typo3/sysext/core/Classes/Utility/MathUtility.php+1 −2
- typo3/sysext/core/Classes/Utility/RootlineUtility.php4+25 −26
- typo3/sysext/core/Classes/Utility/VersionNumberUtility.php+1 −2
- typo3/sysext/core/Tests/Functional/Authentication/Mfa/MfaProviderPropertyManagerTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Database/Query/Expression/ExpressionBuilderTest.php+1 −3
- typo3/sysext/core/Tests/Functional/Database/Query/QueryBuilder/CommonTableExpression/SimpleRootLineTraversalTest.php+10 −12
- typo3/sysext/core/Tests/Functional/Database/Query/QueryBuilder/CommonTableExpression/SimpleSelectCommonTableExpressionTest.php+36 −36
- typo3/sysext/core/Tests/Functional/Database/Query/QueryBuilder/CommonTableExpression/SimpleTreeTraversalTest.php+9 −15
- typo3/sysext/core/Tests/Functional/Database/Query/QueryBuilder/NamedPlaceholderPreparedStatementTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Database/Query/QueryBuilder/PositionPlaceholderPreparedStatementTest.php+5 −5
- typo3/sysext/core/Tests/Functional/Database/Query/Restriction/LimitToTablesRestrictionContainerTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Pagination/QueryBuilderPaginatorTest.php+1 −2
- typo3/sysext/core/Tests/Unit/Imaging/ImageManipulation/CropVariantCollectionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Log/LogRecordTest.php+1 −2
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+1 −3
- typo3/sysext/dashboard/Classes/Widgets/LatestChangedPagesWidget.php+1 −2
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+1 −2
- typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectConverter.php+1 −1
- typo3/sysext/extbase/Classes/Routing/ExtbasePluginEnhancer.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php+1 −2
- typo3/sysext/extensionmanager/Classes/Report/ExtensionStatus.php+1 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php+2 −4
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php+1 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Render/ContentAreaViewHelperTest.php+1 −2
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php+0 −1
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/UploadedFileReferenceConverter.php+1 −3
- typo3/sysext/form/Classes/Service/TranslationService.php+2 −5
- typo3/sysext/frontend/Classes/ContentObject/Menu/CategoryMenuUtility.php+1 −3
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+2 −2
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+3 −6
- typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/AbstractLocalizedPagesTestCase.php+1 −3
- typo3/sysext/impexp/Classes/Export.php+3 −3
- typo3/sysext/impexp/Classes/ImportExport.php2+4 −4
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+7 −7
- typo3/sysext/indexed_search/Classes/Utility/IndexedSearchUtility.php+3 −3
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+12 −14
- typo3/sysext/install/Classes/Configuration/AbstractPreset.php+0 −1
- typo3/sysext/install/Classes/FolderStructure/FileNode.php+1 −2
- typo3/sysext/install/Classes/FolderStructure/RootNode.php+1 −2
- typo3/sysext/install/Classes/Report/InstallStatusReport.php+1 −2
- typo3/sysext/linkvalidator/Classes/Controller/LinkValidatorController.php+1 −2
- typo3/sysext/linkvalidator/Tests/Unit/Linktype/ExternalLinktypeTest.php+1 −2
- typo3/sysext/lowlevel/Documentation/BackendModules/_codesnippets/_MyProvider.php+1 −3
- typo3/sysext/redirects/Tests/Functional/Service/SlugServiceTest.php+1 −2
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php+2 −2
- typo3/sysext/reports/Classes/Report/Status/SystemStatus.php+1 −2
- typo3/sysext/reports/Classes/Report/Status/Typo3Status.php+1 −2
- typo3/sysext/reports/Classes/Status.php+1 −2
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+2 −5
- typo3/sysext/seo/Classes/XmlSitemap/AbstractXmlSitemapDataProvider.php+1 −1
- typo3/sysext/seo/Classes/XmlSitemap/PagesXmlSitemapDataProvider.php+1 −3
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeFlex.php+0 −2
- typo3/sysext/viewpage/Tests/Functional/Controller/ViewModuleControllerTest.php+1 −3
- typo3/sysext/workspaces/Classes/Command/WorkspaceVersionRecordsCommand.php+1 −1
- typo3/sysext/workspaces/Classes/Dependency/DependencyResolver.php+1 −2
- typo3/sysext/workspaces/Classes/Preview/PreviewUriBuilder.php+1 −2
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+2 −6
Review log 2026
Show 1 earlier messages
-
Wouter Wolters uploaded patch set 1 08/04/26, 20:39
-
core-ci voted on patch set 1 V +1 08/04/26, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105948
-
Oliver Klee commented on patch set 1 08/05/26, 06:51
Could we split this up (e.g., by extension or by type of change)? That would make these changes easier and faster to review. -
Oliver Klee commented on patch set 1 08/05/26, 07:43
Reply Unresolved
(For me personally, it would be fastest and easiest to review if we had one change per type of change, e.g., one for inlining, one for using min/max etc.) -
Benni Mack marked it work in progress 08/12/26, 10:47
-
Wouter Wolters uploaded patch set 2
V +108/16/26, 12:31 -
Wouter Wolters marked it ready for review 08/16/26, 12:31
-
core-ci voted on patch set 2 V +1 08/16/26, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106785
-
Andreas Kienast commented on patch set 2 08/17/26, 05:34
NewContentElementController.php:258While this code works, it may be confusing as using `$wizards[$groupKey]` in the next line is necessary. I'd suggest to rewrite it slightly to make it more convenient: ``` $wizardGroup = $this->prepareDependencyOrdering($wizardGroup, 'before'); $wizardGroup = $this->prepareDependencyOrdering($wizardGroup, 'after'); $wizards[$groupKey] = $wizardGroup; ```ImportExport.php:1119Please introduce a proper variable name. `$_` is a dummy for "not used". -
Andreas Kienast voted on patch set 2 CR -1 08/17/26, 05:34
-
Wouter Wolters uploaded patch set 3
CR -1V +108/17/26, 08:17 -
core-ci voted on patch set 3 V +1 08/17/26, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106809
-
Wouter Wolters commented on patch set 3 08/17/26, 08:36
NewContentElementController.php:258ReplyDoneImportExport.php:1119ReplyDone -
Markus Klein commented on patch set 3 08/17/26, 09:05
BackendUserAuthentication.php:1276Not sure about code style here. 1.) comment position 2.) readyability -
Wouter Wolters uploaded patch set 4
V +110/24/26, 13:59 -
core-ci voted on patch set 4 V +1 10/24/26, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112418
-
Markus Klein commented on patch set 4 10/24/26, 18:55
BackendUserAuthentication.php:1276Replykeep itBackendUserAuthentication.php:1282that comment is nonsense. just remove it, the function name says it all. -
Markus Klein commented on patch set 4 10/24/26, 18:56
BackendUserAuthentication.php:1282```suggestion ``` -
Markus Klein commented on patch set 5
V +110/24/26, 18:56Published edit on patch set 4. -
Markus Klein commented on patch set 5 10/24/26, 18:56
BackendUserAuthentication.php:1282ReplyDoneBackendUserAuthentication.php:1282ReplyDone -
Markus Klein commented on patch set 5 CR -1 10/24/26, 19:02
a lot of comment in DB queries got lostRootlineUtility.php:808keep the comments as they wereRootlineUtility.php:1191another lost comment? -
core-ci voted on patch set 5 V +1 10/24/26, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112426
-
Wouter Wolters uploaded patch set 6
CR -1V +110/24/26, 19:14 -
Wouter Wolters commented on patch set 6 10/24/26, 19:14
Reply
DoneRootlineUtility.php:808ReplyDoneRootlineUtility.php:1191ReplyDone -
core-ci voted on patch set 6 V +1 10/24/26, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112427
-
Simon Schaufelberger commented on patch set 6 10/24/26, 22:57
TcaMigration.php:103UnresolvedI would leave the variable here to easily add new entries above as this is a list that often changes and then you only have one changed line in the commitTcaPreparation.php:55UnresolvedNot sure about this one