Review main Ready for review Stale

95133[BUGFIX] Render SVG icons inline for correct dark mode styling

Tim Weisenberger CR +1 V 0 Easy +7 −10 updated 08/06/26, 19:47

Commit message

`SvgIconProvider::generateMarkup()` built a plain `<img src=...>`
tag for the default markup. As an external image resource, its
SVG content is opaque to the surrounding page: CSS rules such as
`currentColor` or dark-mode aware styling cannot reach inside it.

The "inline" markup identifier already avoided this by using
`generateInlineMarkup()` / `getInlineSvg()` to embed the sanitized
SVG contents directly into the DOM, where it can be styled like
any other page content.

`generateMarkup()` now delegates to `generateInlineMarkup()` so
icons requested via the default markup are inline SVG as well
and render correctly in both dark and non-dark mode.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/33/95133/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/33/95133/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Sascha Nowak +1
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 1

Issues 1

Files 2

Review log 23

  1. Tim Weisenberger uploaded patch set 1 08/06/26, 19:28

  2. core-ci voted on patch set 1 V +1 08/06/26, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106029

  3. Sascha Nowak voted on patch set 1 CR +1 08/06/26, 19:46