Review main Ready for review Quiet

95169[BUGFIX] Add link parsing in RTE figcaption

Ulrich Mathes CR -1 V +1 Easy +1 −3 updated 10/01/26, 21:08

Commit message

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/69/95169/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/69/95169/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -1 Needs a vote
    • Sebastian Klein +1
    • Benni Mack -1
  • Verified V +1 Needs a vote
    • Sebastian Klein +1
    • core-ci +1 CI

Merge conflicts 1

Issues 1

Files 1

Review log 46

  1. Ulrich Mathes uploaded patch set 1 08/07/26, 17:28

  2. core-ci voted on patch set 1 V +1 08/07/26, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106132

  3. Ulrich Mathes updated the commit message in patch set 2 V +1 08/07/26, 17:42

  4. core-ci voted on patch set 2 V +1 08/07/26, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106133

  5. Sebastian Klein voted on patch set 2 CR +1 V +1 09/30/26, 14:01

  6. Benni Mack commented on patch set 2 CR -1 10/01/26, 21:08

    ext_localconf.php:94 Unresolved

    with this change, we have a callRecursive - so it wraps everything in figcaption into <p> tags. This means: - Every caption changes, including those with no links. Each existing table or image caption in RTE content gets an extra <p> after the merge. That brings paragraph margins inside captions and breaks CSS like figcaption > a or figcaption:first-child. Alternative: Handle figcaption the way ol/ul already are: ``` figcaption { stripNL = 1 stdWrap.parseFunc = < lib.parseFunc } ```