Review 14.3 Merged

95177[BUGFIX] Allow extbase files in SrcsetViewHelper

Garvin Hicking CR +2 V +2 Normal +74 −1 updated 08/08/26, 13:31

Commit message

The view helper `<f:image.srcset>` should be usable similar to
`<f:image>`. This requires allowing Extbase File and FileReference
objects, which are wrappers for the corresponding core objects.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 711

  1. Garvin Hicking commented on patch set 1 08/08/26, 10:59

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/fluid/Classes/ViewHelpers/Image/SrcsetViewHelper.php
  2. Garvin Hicking commented on patch set 2 08/08/26, 11:03

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 08/08/26, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106171

  4. Garvin Hicking commented on patch set 2 08/08/26, 11:21

    This change is ready for review.
  5. core-ci voted on patch set 2 V -1 08/08/26, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106172

  6. Albrecht Köhnlein uploaded patch set 3 V -1 08/08/26, 11:54

  7. Albrecht Köhnlein uploaded patch set 4 08/08/26, 11:59

  8. core-ci voted on patch set 4 V +1 08/08/26, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106177

  9. core-ci voted on patch set 3 V -1 08/08/26, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106176

  10. Garvin Hicking voted on patch set 4 CR +2 V +2 08/08/26, 13:31

  11. Garvin Hicking merged patch set 5 08/08/26, 13:31