95178[TASK] Sticky language header in comparison view
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Benjamin Kott +1
-
Verified V +2 Done
- Garvin Hicking +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 4
- Build/Sources/Sass/module/_page.scss+1 −1
- Build/Sources/TypeScript/backend/layout-module/sticky-language-header.tsnew+186 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.fluid.html+18 −8
- typo3/sysext/backend/Resources/Public/JavaScript/layout-module/sticky-language-header.jsnew+13 −0
Review log 1320
-
Marcel Küpper uploaded patch set 1 08/08/26, 11:36
-
core-ci voted on patch set 1 V +1 08/08/26, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106175
-
Marcel Küpper uploaded patch set 2
V +108/08/26, 13:06 -
core-ci voted on patch set 2 V +1 08/08/26, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106180
-
Marcel Küpper uploaded patch set 3
V +108/08/26, 13:42 -
core-ci voted on patch set 3 V +1 08/08/26, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106183
-
Garvin Hicking commented on patch set 3 CR +1 V +1 08/08/26, 14:17
I like it :) Thanks! -
Lukas Dörr commented on patch set 3 CR +1 V +1 08/08/26, 18:22
did with two languages: headers pin under the docheader on scroll, column-aligned, and go back on the way up. so Works i guess.Only tested on degoogled Chromium with two languages, so no word on horizontal scroll syncing. -
Eric Harrer commented on patch set 3 08/09/26, 12:31
Thanks, I really like this solution. I noticed two minor visual issues with the sticky language header: 1. When horizontally scrolling the language columns, the sticky header is not clipped at the left edge of the `module-body-container` like the rest of the column content. As a result, it remains visible outside the container. 2. When the language header transitions into its sticky/badge state, there is a noticeable horizontal shift to the right. Since its final position aligns well with the regular content inset of the column, I consider this acceptable. A subtle transition could make the shift feel slightly less abrupt, but I would regard that as optional polish rather than a requirement. I have also documented both observations in Forge issue https://forge.typo3.org/issues/110403, including a short video that demonstrates the behaviour. -
Marcel Küpper uploaded patch set 4
CR +1V +108/09/26, 18:05 -
core-ci voted on patch set 4 V +1 08/09/26, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106225
-
Marcel Küpper commented on patch set 4 08/09/26, 18:13
Reply
Hi Eric, thank you for the feedback. Pushed another patch set. Horizontal scrolling is fixed. Regarding the shift: Pulling it to the left by the amount of padding and border width from the background looks wrong. Now tried a short animation to move it from its original position over to the right, so the border of the sticky note aligns with the column. Also not perfect, but better than before. Feedback is highly appreciated of course. Cheers, Marcel -
Benjamin Kott uploaded patch set 5
V +108/10/26, 10:11 -
Benjamin Kott commented on patch set 5 CR +1 V +1 08/10/26, 10:12
Reply
hey, guys to not stop it from releasing - i did a pass on it and is now good in my oppinion. thx for the work! -
Benjamin Kott commented on patch set 5 08/10/26, 10:12
Reply
Done -
core-ci voted on patch set 5 V -1 08/10/26, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106267
-
core-ci commented on patch set 5 08/10/26, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106267
-
core-ci voted on patch set 5 V +1 08/10/26, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106267
-
Garvin Hicking voted on patch set 5 CR +2 V +2 08/10/26, 13:09
-
Garvin Hicking merged patch set 6 08/10/26, 13:09