Review main Merged

95178[TASK] Sticky language header in comparison view

Marcel Küpper CR +2 V +2 Normal +218 −9 updated 08/10/26, 13:09

Commit message

The language comparison view of the page module can get long, making it
hard to tell which column belongs to which language and translation mode
while scrolling.

A new web component typo3-backend-page-layout-sticky-language-header
carries the header information of a language column twice: the default
slot stays in the flow, a second, initially hidden slot holds a copy
showing flag, language title and translation mode.

As soon as the column header is scrolled out of view, that copy is shown
below the doc header, aligned with its column and clipped at the edges
of the grid. Placement is done in script, since CSS anchor positioning
is not available in all browsers the backend targets.

This is an interim solution, as the language column header is subject to
a general overhaul. It is nevertheless useful, since it is contained in
that header and can be dropped together with it.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1320

  1. Marcel Küpper uploaded patch set 1 08/08/26, 11:36

  2. core-ci voted on patch set 1 V +1 08/08/26, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106175

  3. Marcel Küpper uploaded patch set 2 V +1 08/08/26, 13:06

  4. core-ci voted on patch set 2 V +1 08/08/26, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106180

  5. Marcel Küpper uploaded patch set 3 V +1 08/08/26, 13:42

  6. core-ci voted on patch set 3 V +1 08/08/26, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106183

  7. Garvin Hicking commented on patch set 3 CR +1 V +1 08/08/26, 14:17

    I like it :) Thanks!
  8. Lukas Dörr commented on patch set 3 CR +1 V +1 08/08/26, 18:22

    did with two languages: headers pin under the docheader on scroll, column-aligned, and go back on the way up. so Works i guess.Only tested on degoogled Chromium with two languages, so no word on horizontal scroll syncing.
  9. Eric Harrer commented on patch set 3 08/09/26, 12:31

    Thanks, I really like this solution. I noticed two minor visual issues with the sticky language header: 1. When horizontally scrolling the language columns, the sticky header is not clipped at the left edge of the `module-body-container` like the rest of the column content. As a result, it remains visible outside the container. 2. When the language header transitions into its sticky/badge state, there is a noticeable horizontal shift to the right. Since its final position aligns well with the regular content inset of the column, I consider this acceptable. A subtle transition could make the shift feel slightly less abrupt, but I would regard that as optional polish rather than a requirement. I have also documented both observations in Forge issue https://forge.typo3.org/issues/110403, including a short video that demonstrates the behaviour.
  10. Marcel Küpper uploaded patch set 4 CR +1 V +1 08/09/26, 18:05

  11. core-ci voted on patch set 4 V +1 08/09/26, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106225

  12. Marcel Küpper commented on patch set 4 08/09/26, 18:13

    Reply

    Hi Eric, thank you for the feedback. Pushed another patch set. Horizontal scrolling is fixed. Regarding the shift: Pulling it to the left by the amount of padding and border width from the background looks wrong. Now tried a short animation to move it from its original position over to the right, so the border of the sticky note aligns with the column. Also not perfect, but better than before. Feedback is highly appreciated of course. Cheers, Marcel
  13. Benjamin Kott uploaded patch set 5 V +1 08/10/26, 10:11

  14. Benjamin Kott commented on patch set 5 CR +1 V +1 08/10/26, 10:12

    Reply

    hey, guys to not stop it from releasing - i did a pass on it and is now good in my oppinion. thx for the work!
  15. Benjamin Kott commented on patch set 5 08/10/26, 10:12

    Reply

    Done
  16. core-ci voted on patch set 5 V -1 08/10/26, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106267

  17. core-ci commented on patch set 5 08/10/26, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106267

  18. core-ci voted on patch set 5 V +1 08/10/26, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106267

  19. Garvin Hicking voted on patch set 5 CR +2 V +2 08/10/26, 13:09

  20. Garvin Hicking merged patch set 6 08/10/26, 13:09