Review 14.3 Merged

95199[BUGFIX] Fix free mode rendering in comparison view

Garvin Hicking CR +2 V +2 Hard +545 −31 updated 08/10/26, 19:56

Commit message

The layout module binds translations to the default
language (#106649). In free mode that binding is
missing a target and all items get rendered in the
first row. Additionally all items got hidden, when
the default language column had not items.

The language comparison now always shows connected
language items as rows and languages in free mode
independently from the default language binding.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 1017

  1. Garvin Hicking commented on patch set 1 08/10/26, 08:20

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.fluid.html
  2. core-ci voted on patch set 1 V -1 08/10/26, 08:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106264

  3. Benni Mack commented on patch set 2 V -1 08/10/26, 11:31

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V -1 08/10/26, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106273

  5. Marcel Küpper uploaded patch set 3 V -1 08/10/26, 17:28

  6. core-ci voted on patch set 3 V +1 08/10/26, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106300

  7. Marcel Küpper uploaded patch set 4 V +1 08/10/26, 18:46

  8. core-ci voted on patch set 4 V -1 08/10/26, 19:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106314

  9. Marcel Küpper uploaded patch set 5 V -1 08/10/26, 19:08

  10. core-ci voted on patch set 5 V -1 08/10/26, 19:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106316

  11. Marcel Küpper uploaded patch set 6 V -1 08/10/26, 19:22

  12. core-ci voted on patch set 6 V -1 08/10/26, 19:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106317

  13. Marcel Küpper uploaded patch set 7 V -1 08/10/26, 19:32

  14. core-ci voted on patch set 7 V +1 08/10/26, 19:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106318

  15. Garvin Hicking marked it ready for review 08/10/26, 19:56

  16. Garvin Hicking voted on patch set 7 CR +2 V +2 08/10/26, 19:56

  17. Garvin Hicking merged patch set 8 08/10/26, 19:56