Review 14.3 Merged

95205[TASK] Decouple session cookie emission from user authentication

Benni Mack CR +2 V +2 Normal +66 −24 updated 08/11/26, 05:57

Commit message

Applying the session cookie to a PSR-7 response is now handled by
the new `SetCookieService->applyCookieToResponse()` method, which
receives the user session, the evaluated cookie behavior and the
normalized parameters of the current request. The authentication
middlewares of backend and frontend use this service directly.

`AbstractUserAuthentication->appendCookieToResponse()` is reduced to
an internal shim delegating to the service and no longer falls
back to reading the request from `$GLOBALS['TYPO3_REQUEST']`,
resolving a long-standing todo in the authentication object.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Benni Mack commented on patch set 1 08/10/26, 13:28

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/10/26, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106285

  3. Benni Mack voted on patch set 1 CR +2 V +2 08/11/26, 05:57

  4. Benni Mack merged patch set 2 08/11/26, 05:57