Review 14.3 Merged

95237[BUGFIX] Correctly parse ORDER BY clauses with FIND_IN_SET

Stefan Bürk CR +2 V +2 Normal +63 −3 updated 08/11/26, 00:05

Commit message

This patch add correct handling for complex ORDER BY clauses to
QueryHelper::parseOrderBy(), to ensure that only top-level delimiters
are taken into account when splitting the order columns.

The idea is to perform a depth search for delimiters inside parentheses
to skip splitting for these. As queries should not be parsed in loops
anyway, the performance implications should be negligible. FWIW, to
skip the new logic when it is not needed, the implementation first
checks whether there are any parentheses at all inside the ORDER BY
declaration in question.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Stefan Bürk commented on patch set 1 08/10/26, 23:54

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/11/26, 00:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106345

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 08/11/26, 00:05

  4. Stefan Bürk merged patch set 2 08/11/26, 00:05